[B][SRU][PATCH 0/1] ext4: fix mount failure with quota configured as module
Po-Hsu Lin
po-hsu.lin at canonical.com
Tue Mar 24 09:19:16 UTC 2020
== SRU Justification ==
Commit d65d87a07476 ("ext4: improve explanation of a mount failure
caused by a misconfigured kernel") applied to our Bionic tree via the
stable-update process does not consider the situation when quota support
was configured as a module.
This will cause failure to quotactl04 test from ubuntu_ltp_syscalls:
<<<test_start>>>
tag=quotactl04 stime=1585032076
cmdline="quotactl04"
contacts=""
analysis=exit
<<<test_output>>>
incrementing stop
tst_kconfig.c:62: INFO: Parsing kernel config '/boot/config-4.15.0-92-generic'
tst_device.c:244: INFO: Using test device LTP_DEV='/dev/loop0'
tst_test.c:1229: INFO: Timeout per run is 0h 05m 00s
tst_mkfs.c:90: INFO: Formatting /dev/loop0 with ext4 opts='' extra opts='-O quota,project'
mke2fs 1.44.1 (24-Mar-2018)
safe_macros.c:769: BROK: quotactl04.c:109: mount(/dev/loop0, mntpoint, ext4, 0, 0x55edd2c1ab1d) failed: EINVAL (22)
Summary:
passed 0
failed 0
skipped 0
warnings 0
<<<execution_status>>>
initiation_status="ok"
duration=2 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=2
<<<test_end>>>
And from the syslog you will see:
LTP: starting quotactl04
EXT4-fs (loop0): The kernel was not built with CONFIG_QUOTA and CONFIG_QFMT_V2
== Fix ==
* 9db176bceb5c ("ext4: fix mount failure with quota configured as module")
This patch can be cherry-picked into Bionic and it's already in Focal.
I didn't see commit d65d87a07476 in Eoan / Disco, so I think they don't
need this patch.
== Test ==
Test kernel could be found here:
https://people.canonical.com/~phlin/kernel/lp-1868665-quota-module/
Tested with the quotactl04 test from ubuntu_ltp_syscalls and it has
passed as expected.
== Regression Potential ==
Low, this patch is specific to ext4 quota support. And it's just using
a more general way to do the check.
Jan Kara (1):
ext4: fix mount failure with quota configured as module
fs/ext4/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.7.4
More information about the kernel-team
mailing list