NAK[F/Unstable]: [PATCH 0/1][SRU][B][F][Unstable] Stop using get_scalar_status

Seth Forshee seth.forshee at canonical.com
Fri Mar 20 22:38:36 UTC 2020


On Wed, Mar 11, 2020 at 10:00:04PM +0800, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1865402
> 
> [Impact]
> The get_scalar_status command was provided by ODM engineer and was newly
> introduced to determinate whether scalar is responsible for the backlight
> adjustment. That guy asked the scalar vendor to add this command and the
> command works as expected. But there is already a command in the Dell AIO
> scalar UART command spec. which can do the same thing since 2015, and the
> newly introduced get_scalar_status command is undocumented. To prevent
> from introducing regression in the future and to align with what Windows
> uses, replace this command with get_display_mode command.
> 
> [Fix]
> Replace get_scalar_status command with get_display_mode command.
> 
> [Test]
> Verified on new Dell AIO platforms.
> 
> [Regression Potential]
> Low, the command is already in the spec. since 2015.

The patches for focal and unstable do not apply. This looks like it has
to do with the revert of "UBUNTU: SAUCE: platform/x86:
dell-uart-backlight: move retry block" and that your patch may need to
be updated in light of that revert.

Thanks,
Seth



More information about the kernel-team mailing list