[PATCH 0/1][SRU][B][F][Unstable] Stop using get_scalar_status
acelan.kao at canonical.com
Fri Mar 13 01:33:27 UTC 2020
Thanks, Stefan, you are right, I missed Eoan >_<
I just submitted the Eoan patch to the same thread.
Stefan Bader <stefan.bader at canonical.com> 於 2020年3月12日 週四 下午10:59寫道：
> On 11.03.20 15:00, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1865402
> > [Impact]
> > The get_scalar_status command was provided by ODM engineer and was newly
> > introduced to determinate whether scalar is responsible for the backlight
> > adjustment. That guy asked the scalar vendor to add this command and the
> > command works as expected. But there is already a command in the Dell AIO
> > scalar UART command spec. which can do the same thing since 2015, and the
> > newly introduced get_scalar_status command is undocumented. To prevent
> > from introducing regression in the future and to align with what Windows
> > uses, replace this command with get_display_mode command.
> > [Fix]
> > Replace get_scalar_status command with get_display_mode command.
> > [Test]
> > Verified on new Dell AIO platforms.
> > [Regression Potential]
> > Low, the command is already in the spec. since 2015.
> > AceLan Kao (1):
> > UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add get_display_mode
> > command
> > drivers/platform/x86/dell-uart-backlight.c | 91 +++++++++++-----------
> > drivers/platform/x86/dell-uart-backlight.h | 7 +-
> > 2 files changed, 52 insertions(+), 46 deletions(-)
> The bug report has a nomination for Eoan as well. What is correct? And it would
> be good to not leave the tasks in incomplete or new state.
More information about the kernel-team