ACK: [SRU][Eoan][PATCH 0/5] Fix hang issue if sof fails to load firmware

[Stefan Bader]

On 21.02.20 10:00, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1861837
> 
> If the sof driver fails to load the firmware, it doesn't release the
> resource, then it make the system hang when suspending and resuming.
> 
> After this patchset is applied, please also apply the patchset we
> just reverted 2 weeks ago, since this patchset is the fixing patches
> for the patches we reverted (#1857409). If need me to resend the
> reverted patches, I will resend them.
> 
> 
> [Impact]
> The machine hangs during suspend/resume if the sof driver fails to
> load firmware.
> 
> [Fix]
> This bug is fixed in the mainline kernel v5.6-rc1, now backported
> those patches to ubuntu kernel
> 
> [Test Case]
> sudo mv /lib/firmware/intel/sof /lib/firmware/intel/sof-bak, reboot
> then suspend and resume, the system will not hang anymore
> 
> And if the sof driver load the firmware successfully, the audio
> functions all worked well as before.
> 
> [Regression Risk]
> Low, the patches are backported from upstream kernel, and I tested
> these patches on Lenovo and Dell dmic machines.
> 
> 
> Kai Vehmanen (2):
>   ASoC: hdac_hda: Fix error in driver removal after failed probe
>   ASoC: SOF: trace: fix unconditional free in trace release
> 
> Pierre-Louis Bossart (2):
>   ASoC: SOF: core: free trace on errors
>   ASoC: SOF: core: release resources on errors in probe_continue
> 
> Ranjani Sridharan (1):
>   ASoC: SOF: Introduce state machine for FW boot
> 
>  sound/soc/codecs/hdac_hda.c          |  4 +-
>  sound/soc/sof/core.c                 | 86 ++++++++++++++++++++--------
>  sound/soc/sof/intel/hda-loader-skl.c |  1 -
>  sound/soc/sof/intel/hda-loader.c     |  1 -
>  sound/soc/sof/intel/hda.c            |  4 +-
>  sound/soc/sof/ipc.c                  | 17 ++----
>  sound/soc/sof/loader.c               | 19 ++++--
>  sound/soc/sof/pm.c                   | 25 +++++++-
>  sound/soc/sof/sof-priv.h             | 11 +++-
>  sound/soc/sof/trace.c                |  7 ++-
>  10 files changed, 125 insertions(+), 50 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200312/7e36964c/attachment-0001.sig>