[PATCH 1/1] [Eoan/Focal?] scsi: Revert "target/core: Inline transport_lun_remove_cmd()"

[Andrea Righi]

On Thu, Mar 12, 2020 at 09:08:18AM +0100, Stefan Bader wrote:
> On 28.02.20 22:17, Pavel Zakharov wrote:
> > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-hwe/+bug/1862682
> > 
> > scsi: Revert "target/core: Inline transport_lun_remove_cmd()"
> > 
> > Commit 83f85b8ec305 postponed the percpu_ref_put(&se_cmd->se_lun->lun_ref)
> > call from command completion to the time when the final command reference
> > is dropped. That approach is not compatible with the iSCSI target driver
> > because the iSCSI target driver keeps the command with the highest stat_sn
> > after it has completed until the next command is received (see also
> > iscsit_ack_from_expstatsn()). Fix this regression by reverting commit
> > 83f85b8ec305.
> > 
> > Fixes: 83f85b8ec305 ("scsi: target/core: Inline transport_lun_remove_cmd()")
> > Cc: Pavel Zakharov <pavel.zakharov at delphix.com>
> > Cc: Mike Christie <mchristi at redhat.com>
> > Cc: <stable at vger.kernel.org>
> > Link: https://lore.kernel.org/r/20200210051202.12934-1-bvanassche@acm.org
> > Reported-by: Pavel Zakharov <pavel.zakharov at delphix.com>
> > Signed-off-by: Bart Van Assche <bvanassche at acm.org>
> > Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
> > ---
> 
> Since the HWE kernel is a backport from the Eoan kernel, this would affect
> anything v5.3 and later. I modified the bug report accordingly (when applying,
> this should go into Eoan). Not sure about Focal, it could already have landed
> while pulling in stable updates.

I confirm this one is already applied to Focal.

Thanks,
-Andrea