ACK/cmnt: [SRU][B][PATCH 0/4] UBUNTU: SAUCE: Updates to Exar USB serial driver

Kleber Souza kleber.souza at canonical.com
Tue Mar 10 11:35:59 UTC 2020


On 19.02.20 05:38, Shrirang Bagul wrote:
> BugLink: https://bugs.launchpad.net/bugs/1863834
> 
> [Impact]
> This update adds the latest vendor release version on the Exar USB serial device.
> 
> [Fixes]
> New features include:
> 1. Fix for RX fail after wake-up from sleep (S3/S4)
> 2. Removes unnecessary debug messages
> 
> Changelog:
> 
> Version 1B, 11/6/2015
> Fixed Bug: The conditional logic to support kernel 3.9 was
> incorrect(line 396 in xr_usb_serial_common.c).
> 
> Version 1A, 1/9/2015
> This driver will work with any USB UART function in these Exar devices:
> XR21V1410/1412/1414
> XR21B1411
> XR21B1420/1422/1424
> XR22801/802/804
> 
> Exar serial devices are typically enumerated as /dev/ttyXRUSB[0-3].
> 
> [Regression Potential]
> Low. This driver binds to Exar USB Serial devices on the Dell Edge 300x GW.
> These updates are being carried in the linux-oem (4.15.y) kernel for more
> than 2 years without any regressions.
> 
> [Note]
> This vendor driver doesn't follow upstream coding style for Linux kernel.
> For tracking, old buglinks against linux-oem kernel are included in the
> individual patch descriptions.
> 
> Shrirang Bagul (4):
>   UBUNTU: SAUCE: xr-usb-serial: Update driver for Exar USB serial ports
>   UBUNTU: SAUCE: xr-usb-serial: re-initialise baudrate after resume from
>     S3/S4
>   UBUNTU: SAUCE: xr-usb-serial: Changes to support updates in struct
>     gpio_chip
>   UBUNTU: SAUCE: xr-usb-serial: fix kbuild
> 
>  ubuntu/xr-usb-serial/Kconfig                |  11 +
>  ubuntu/xr-usb-serial/Makefile               |  14 +-
>  ubuntu/xr-usb-serial/README.txt             |   3 +
>  ubuntu/xr-usb-serial/xr_get_smbios.c        | 350 +++++++++++++++++
>  ubuntu/xr-usb-serial/xr_get_smbios.h        | 237 ++++++++++++
>  ubuntu/xr-usb-serial/xr_usb_serial_common.c | 405 +++++++++++++++-----
>  ubuntu/xr-usb-serial/xr_usb_serial_common.h |  20 +-
>  ubuntu/xr-usb-serial/xr_usb_serial_hal.c    | 244 ++++++++++--
>  ubuntu/xr-usb-serial/xr_usb_serial_ioctl.h  |   7 +
>  9 files changed, 1147 insertions(+), 144 deletions(-)
>  create mode 100644 ubuntu/xr-usb-serial/Kconfig
>  create mode 100644 ubuntu/xr-usb-serial/xr_get_smbios.c
>  create mode 100644 ubuntu/xr-usb-serial/xr_get_smbios.h
> 

The code has several styling issues, but as we have been carrying it for
a long time already in linux-oem it wouldn't be sensible to fix them.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>



More information about the kernel-team mailing list