ACK: [PATCH 1/1] [bionic hwe kernel] scsi: Revert "target/core: Inline transport_lun_remove_cmd()"

Seth Forshee seth.forshee at
Fri Mar 6 17:53:35 UTC 2020

On Fri, Feb 28, 2020 at 04:17:56PM -0500, Pavel Zakharov wrote:
> BugLink:
> scsi: Revert "target/core: Inline transport_lun_remove_cmd()"
> Commit 83f85b8ec305 postponed the percpu_ref_put(&se_cmd->se_lun->lun_ref)
> call from command completion to the time when the final command reference
> is dropped. That approach is not compatible with the iSCSI target driver
> because the iSCSI target driver keeps the command with the highest stat_sn
> after it has completed until the next command is received (see also
> iscsit_ack_from_expstatsn()). Fix this regression by reverting commit
> 83f85b8ec305.
> Fixes: 83f85b8ec305 ("scsi: target/core: Inline transport_lun_remove_cmd()")
> Cc: Pavel Zakharov <pavel.zakharov at>
> Cc: Mike Christie <mchristi at>
> Cc: <stable at>
> Link:
> Reported-by: Pavel Zakharov <pavel.zakharov at>
> Signed-off-by: Bart Van Assche <bvanassche at>
> Signed-off-by: Martin K. Petersen <martin.petersen at>

Acked-by: Seth Forshee <seth.forshee at>

More information about the kernel-team mailing list