ACK/Cmnt: [SRU][focal][pull] pull RoCE Disable from 5.5

Stefan Bader stefan.bader at canonical.com
Fri Jul 31 09:43:51 UTC 2020


On 30.07.20 22:08, Jeff Lane wrote:
> BugLink: https://bugs.launchpad.net/bugs/1877270
> 
> The following changes since commit 98c4545e2d65ed35c31056f72c4da20f6b5ea0d0:
> 
>   UBUNTU: Ubuntu-5.4.0-42.46 (2020-07-09 19:50:26 -0400)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~bladernr/ubuntu/+source/linux/+git/focal 1877270-pull-roce-disable-from-5.5
> 
> for you to fetch changes up to bc9828bb177ef3eff1723c58c949b360b9f137ed:
> 
>   IB/mlx5: Do reverse sequence during device removal (2020-07-27 18:00:28 -0400)
> 
> ----------------------------------------------------------------
> Michael Guralnik (6):
>       devlink: Add new "enable_roce" generic device param
>       net/mlx5: Document flow_steering_mode devlink param
>       net/mlx5: Handle "enable_roce" devlink param
>       IB/mlx5: Rename profile and init methods
>       IB/mlx5: Load profile according to RoCE enablement state
>       net/mlx5: Add devlink reload
> 
> Parav Pandit (1):
>       IB/mlx5: Do reverse sequence during device removal
> 
> zhong jiang (1):
>       net/mlx5: Remove unneeded variable in mlx5_unload_one
> 
>  .../networking/device_drivers/mellanox/mlx5.rst    | 21 +++++++++++
>  Documentation/networking/devlink-params-mlx5.txt   | 17 +++++++++
>  Documentation/networking/devlink-params.txt        |  4 +++
>  drivers/infiniband/hw/mlx5/ib_rep.c                |  2 +-
>  drivers/infiniband/hw/mlx5/ib_rep.h                |  2 +-
>  drivers/infiniband/hw/mlx5/main.c                  | 41 +++++++++++----------
>  drivers/net/ethernet/mellanox/mlx5/core/devlink.c  | 42 ++++++++++++++++++++++
>  drivers/net/ethernet/mellanox/mlx5/core/main.c     |  8 ++---
>  .../net/ethernet/mellanox/mlx5/core/mlx5_core.h    |  3 ++
>  include/linux/mlx5/driver.h                        | 11 ++++++
>  include/net/devlink.h                              |  4 +++
>  net/core/devlink.c                                 |  5 +++
>  12 files changed, 134 insertions(+), 26 deletions(-)
>  create mode 100644 Documentation/networking/devlink-params-mlx5.txt
> 

The SRU team recently started some discussion about the regression potential
section to be more a description of worst case scenario in case a change goes
wrong. In this case there are changes to generic devlink code. But from what I
see that adds a possible driver parameter which has no effect unless a driver
evaluates that parameter.
So I guess the regression section should describe somehow what kind of bug
reports might be coming in worst case. This is my reading of the recent discussion.

From our side, the generic code changes are acceptable and the rest is isolated
in a specific driver which (given one got the hw) can be verified. So

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200731/18bf5c71/attachment.sig>


More information about the kernel-team mailing list