ACK/Cmnt: [SRU] [F/Unstable/OEM-5.6] [PATCH v2 0/3] Add support for Atlantic NIC firmware v4

Stefan Bader stefan.bader at canonical.com
Fri Jul 24 07:56:06 UTC 2020


On 23.07.20 18:38, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1886908
> 
> [Impact]
> Atlantic NIC doesn't work.
> 
> [Fix]
> Add firmware v4 support.
> 
> [Test]
> With the patch applied, the driver probe success.
> Using iperf as a smoketest shows positive result.
> 
> [Regression Potential]
> None. We were contacted by Marvell after I sent the patch to upstream,
> and they told us firmware v4 is created specifically for this upcoming
> platform. There are no firmware v4 in production.
> 
> v2:
> - Replaced my patch with new code drop from Marvell.

In general all is isolated to certain hw. And at least some testing was done.
But reading about a v2 caused by updated code, I am getting doubts about its
stability. The stable distro kernels are not a testing ground and SRU has an
emphasis on "stable". So I really would prefer to get submissions which are not
fixing broken existing functionality and might still undergo some change at
least delayed a bit to give baking time in unstable and/or respective OEM kernels.

> 
> Dmitry Bogdanov (1):
>   net: atlantic: add support for FW 4.x
> 
> Mark Starovoytov (1):
>   net: atlantic: align return value of ver_match function with function
>     name
> 
> Nikita Danilov (1):
>   net: atlantic: simplify hw_get_fw_version() usage
> 
>  .../net/ethernet/aquantia/atlantic/aq_hw.h    |  2 +-
>  .../net/ethernet/aquantia/atlantic/aq_nic.c   |  6 +-
>  .../aquantia/atlantic/hw_atl/hw_atl_llh.c     | 17 ++++-
>  .../aquantia/atlantic/hw_atl/hw_atl_llh.h     | 10 ++-
>  .../atlantic/hw_atl/hw_atl_llh_internal.h     | 11 ++-
>  .../aquantia/atlantic/hw_atl/hw_atl_utils.c   | 67 ++++++++++++-------
>  .../aquantia/atlantic/hw_atl/hw_atl_utils.h   |  4 +-
>  7 files changed, 76 insertions(+), 41 deletions(-)
>

For this time since this is more of my sentiment and not established guidelines
(though I believe I am not grudging about this for the first time)...

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200724/0cc8816a/attachment.sig>


More information about the kernel-team mailing list