ACK/Cmnt: [SRU D 0/3] Fix TLS sockets partial reads

[Stefan Bader]

On 22.07.20 21:33, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1888381
> 
> tls net kernel selftests start timing out.
> 
> Kleber has identified the backport of commit 692d7b5d1f91 ("tls: Fix recvmsg()
> to be able to peek across multiple records") as the responsible for this
> regression.
> 
> It turns out this commit has 4 fixups upstream, 3 of which can be easily cherry
> picked, while the fourth one seems related to TLS 1.3 support, which is not
> included in our 5.0 kernels yet.
> 
> Picking those 3 commits allow the tests to pass without issues.
> 
> [Impact]
> Partial reads on TLS sockets will cause processes to wait indefinitively.
> 
> [Test case]
> Run tls net selftests from the kernel source tree.
> 
> [Regression potential]
> We only touch code on the TLS socket family itself, so regressions on
> subsystems other than the one we are fixing is highly unlikely.
> 
> Jakub Kicinski (3):
>   net/tls: fix lowat calculation if some data came from previous record
>   net/tls: fix no wakeup on partial reads
>   net/tls: fix poll ignoring partially copied records
> 
>  net/tls/tls_sw.c | 22 +++++++++-------------
>  1 file changed, 9 insertions(+), 13 deletions(-)
> 

I guess right now the target picked for the bug report is as close as it can
get. But still should not be left in new state. And a serverity would be nice,
too. [fixed]

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200723/7d56efba/attachment.sig>