ACK: [PATCH 0/1][FOCAL][RISC-V][SRU] riscv: use 16KB kernel stack on 64-bit
Andrea Righi
andrea.righi at canonical.com
Mon Jul 20 08:57:19 UTC 2020
On Mon, Jul 20, 2020 at 09:49:50AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> For risc-v focal kernel:
>
> == SRU Justification Focal RISC-V ==
>
> https://bugs.launchpad.net/bugs/1879470
>
> Running stress-ng coverage tests on an ARM64 VM gcov 5.4.0-26-generic
> focal kernel trips an oops because the kernel stack is too small.
>
> == Fix ==
>
> Upstream commit:
>
> commit 0cac21b02ba5f3095fd2dcc77c26a25a0b2432ed
> Author: Andreas Schwab <schwab at suse.de>
> Date: Mon Jul 6 14:32:26 2020 +0200
>
> riscv: use 16KB kernel stack on 64-bit
>
> == Test ==
>
> Without the fix, we hit stack overflows. Run stress-ng kernel-coverage.sh
> script with gcov enabled and the issue occurs. With the fix the issue
> does not occur.
>
> == Regression Potential ==
>
> This fix just affects 64 bit RISC-V and doubles the stack size. In
> systems that run thousands of processes will see more memory being
> consumed, but this most probably won't bite anyone because RISC-V
> systems are generally not used in this manner.
Makes sense to me.
Acked-by: Andrea Righi <andrea.righi at canonical.com>
More information about the kernel-team
mailing list