NACK: [SRU][Focal][PATCH 1/5] AsoC: amd: add missing snd- module prefix to the acp3x-rn driver kernel module

Hui Wang hui.wang at canonical.com
Thu Jul 16 09:17:32 UTC 2020


On 2020/7/16 下午5:12, Stefan Bader wrote:
> On 16.07.20 11:05, Hui Wang wrote:
>> On 2020/7/16 下午3:39, Stefan Bader wrote:
>>> On 16.07.20 03:24, Hui Wang wrote:
>>>> From: Jaroslav Kysela <perex at perex.cz>
>>>>
>>>> BugLink: https://bugs.launchpad.net/bugs/1887734
>>>>
>>>> Signed-off-by: Jaroslav Kysela <perex at perex.cz>
>>>> Acked-by: Alex Deucher <alexander.deucher at amd.com>
>>>> Cc: Mark Brown <broonie at kernel.org>
>>>> Cc: vijendar.mukunda at amd.com
>>>> Cc: Alexander.Deucher at amd.com
>>>> Link: https://lore.kernel.org/r/20200625115829.791750-1-perex@perex.cz
>>>> Signed-off-by: Mark Brown <broonie at kernel.org>
>>>> (cherry picked from commit bc5c7f55f5ea91e137fc7939435ed2e2bb6e5a15)
>>>> Signed-off-by: Hui Wang <hui.wang at canonical.com>
>>>> ---
>>> In devel you can mix things. But for SRU addresses one issue and not also makes
>>> some unrelated changes.
>>>
>>> See:
>>> https://wiki.ubuntu.com/StableReleaseUpdates
>> Sorry, a little bit confused. Do you mean I should put [1/5] and [2/5] into a
>> SRU and put the rest patches into another SRU for Focal?
> Yes, I think that seemed the functional split. So 1+2 is the firmware and 3-5
> are microphone level changes. Both are not related and for stable updates we
> should try to keep things isolated. Because of testing but also if something
> needs to be reverted, it is clearly apart.

OK, got it, will change it in the V2.

Thanks,

Hui.

> -Stefan
>
>> Thanks,
>>
>> Hui.
>>
>>> -Stefan
>>>
>>>>    sound/soc/amd/renoir/Makefile | 7 ++++---
>>>>    1 file changed, 4 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/sound/soc/amd/renoir/Makefile b/sound/soc/amd/renoir/Makefile
>>>> index e4371932a55a..4a82690aec16 100644
>>>> --- a/sound/soc/amd/renoir/Makefile
>>>> +++ b/sound/soc/amd/renoir/Makefile
>>>> @@ -2,6 +2,7 @@
>>>>    # Renoir platform Support
>>>>    snd-rn-pci-acp3x-objs    := rn-pci-acp3x.o
>>>>    snd-acp3x-pdm-dma-objs    := acp3x-pdm-dma.o
>>>> -obj-$(CONFIG_SND_SOC_AMD_RENOIR)     += snd-rn-pci-acp3x.o
>>>> -obj-$(CONFIG_SND_SOC_AMD_RENOIR)     += snd-acp3x-pdm-dma.o
>>>> -obj-$(CONFIG_SND_SOC_AMD_RENOIR_MACH)    += acp3x-rn.o
>>>> +snd-acp3x-rn-objs    := acp3x-rn.o
>>>> +obj-$(CONFIG_SND_SOC_AMD_RENOIR)    += snd-rn-pci-acp3x.o
>>>> +obj-$(CONFIG_SND_SOC_AMD_RENOIR)    += snd-acp3x-pdm-dma.o
>>>> +obj-$(CONFIG_SND_SOC_AMD_RENOIR_MACH)    += snd-acp3x-rn.o
>>>>
>



More information about the kernel-team mailing list