NACK: [SRU][Bionic][PATCH 0/2] Cutting and Pasting files from NFS sec=sys to NFS sec=krb5p causes NFS to hang

Andrea Righi andrea.righi at canonical.com
Thu Jul 16 08:24:16 UTC 2020


On Thu, Jul 16, 2020 at 01:54:40PM +1200, Matthew Ruffell wrote:
...
> [Fix]
> 
> The fix landed in 5.1-rc1, in the following commit:
> 
> commit 02ef04e432babf8fc703104212314e54112ecd2d
> Author: Chuck Lever <chuck.lever at oracle.com>
> Date: Mon Feb 11 11:25:25 2019 -0500
> Subject: NFS: Account for XDR pad of buf->pages
> Link: https://github.com/torvalds/linux/commit/02ef04e432babf8fc703104212314e54112ecd2d 
> 
> The above commit more or less relies on the below commit as a dependency, and is
> included in the SRU:
> 
> commit cf500bac8fd48b57f38ece890235923d4ed5ee91
> Author: Chuck Lever <chuck.lever at oracle.com>
> Date: Mon Feb 11 11:25:20 2019 -0500
> Subject: SUNRPC: Introduce rpc_prepare_reply_pages()
> Link: https://github.com/torvalds/linux/commit/cf500bac8fd48b57f38ece890235923d4ed5ee91
> 
> It appears that some NFS calls return a NFS payload which is not a multiple of
> 4 bytes, but any payload sent over the network needs to be padded to an exact
> multiple of 4 bytes. It seems cutting and pasting from Nautilus triggers one
> such payload which is missing a byte, and it causes the NFS subsystem to hang
> during packet transmission. The fix ensures that all payloads use correct
> padding.

I think we may need to apply also:

 29e7ca715f2a ("NFS: Fix handling of reply page vector")

that seems to fix a bug introduced by 02ef04e432ba. If that's the case
could you re-send the patch set including also this fix.

Thanks,
-Andrea



More information about the kernel-team mailing list