ACK/Cmnt: [PATCH v2 0/2][SRU][B/F/OEM-B/OEM-OSP1-B/OEM-5.6] Fix System stops responding while entering S3 with SD card installed

Shane Lin shane.lin at canonical.com
Thu Jul 16 02:43:12 UTC 2020


Patch 2 need to be backported because of there's a patch changes the structure:

38986ffa6a74 xhci: use port structures instead of port arrays in
xhci.c functions

- __le32 __iomem **port_array;
+ struct xhci_port **ports;

So for the older kernel, we need to use `port_array` instead of `ports`.

Thanks for your reminder, I'll attach the more information next time.

On Wed, Jul 15, 2020 at 3:55 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 15.07.20 05:30, Hsuan-Yu Lin wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1880519
> >
> > [Impact]
> > The system stops responding while entering S3, screen will be lit up
> > if touchpad is triggered by finger. Cursor could be seen with black background,
> > but system is not responding to any input.
> >
> > [Fix]
> > Patchset[1] for fix this issue currently landed in upstream,
> > so we backported them:
> >
> > [1]:
> > b3d71abd135e xhci: Poll for U0 after disabling USB2 LPM
> > f0c472a6da51 xhci: Return if xHCI doesn't support LPM
> >
> > [Test]
> > With the above patch applied, run:
> > sudo fwts --s3-sleep-delay=30 --s3-multiple=30 -p s3
> >
> > Can passed 30 times.
> >
> > [Regression Potential]
> > Low, the patch is just like a safeguard,
> > doesn't really change any behavior.
> >
> > v2: Fix the wrong email subject.
> >
> > Kai-Heng Feng (2):
> >   xhci: Return if xHCI doesn't support LPM
> >   xhci: Poll for U0 after disabling USB2 LPM
> >
> >  drivers/usb/host/xhci.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> As Juerg mentioned a little backport hinting would be nice. Switching between
> the 2 mails I cannot see anything, so it must be minor.
>
>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list