ACK/cmt: [SRU B 0/1] Revert code that causes crashes on default configurations
khalid.elmously at canonical.com
Wed Jul 8 23:02:59 UTC 2020
On 2020-07-08 18:31:02 , Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1886668
> On systems using cgroups and sockets extensively, like docker, kubernetes,
> lxd, libvirt, a crash might happen when using linux 4.15.0-109-generic.
> Revert the patch that disables sk_alloc cgroup refcounting when tasks
> are added to net_prio cgroup.
> [Test case]
> Test that such environments where the issue is reproduced survive some hours of
> uptime. A different bug was reproduced with a work-in-progress code and was not
> reproduced with the culprit reverted.
> [Regression potential]
> The reverted commit fix a memory leak on similar scenarios. But a leak is
> better than a crash. Two other bugs have been opened to track a real fix for
> this issue and the leak.
> Thadeu Lima de Souza Cascardo (1):
> UBUNTU: SAUCE: Revert "netprio_cgroup: Fix unlimited memory leak of v2
> net/core/netprio_cgroup.c | 2 --
> 1 file changed, 2 deletions(-)
Thanks for debugging this!
And agreed with your reasoning - especially considering the leak has been around for almost 5 years.
Acked-by: Khalid Elmously <khalid.elmously at canonical.com>
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
More information about the kernel-team