APPLIED [OEM-5.6] Re: [SRU] [Unstable/OEM-5.6] [PATCH 00/13] Add generic LED class support for audio LED

Timo Aaltonen timo.aaltonen at canonical.com
Wed Jul 1 11:27:47 UTC 2020


On 1.7.2020 13.51, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1885896
> 
> [Impact]
> Like GPIO controlled LED, COEF controlled LED also need LED class
> support, in order to be used by SoF driver.
> 
> [Fix]
> Convert all HDA vendor-specific LED control to generic LED class.
> 
> [Test]
> After applying the patch series, COEF controlled LED is exported under
> /sys/class/leds/, so SoF driver now can control the micmute LED.
> 
> Also verified on GPIO based micmute LED, it also works fine.
> 
> [Regression Potential]
> Low. Though there are 13 patches, most of them are straightforward
> conversion.
> 
> Takashi Iwai (13):
>   ALSA: hda: generic: Always call led-trigger for mic mute LED
>   ALSA: hda: generic: Add a helper for mic-mute LED with LED classdev
>   ALSA: hda/realtek: Convert to cdev-variant of mic-mute LED controls
>   ALSA: hda/conexant: Convert to cdev-variant of mic-mute LED controls
>   ALSA: hda/sigmatel: Convert to cdev-variant of mic-mute LED controls
>   ALSA: hda: generic: Drop unused snd_hda_gen_fixup_micmute_led()
>   ALSA: hda: generic: Drop the old mic-mute LED hook
>   ALSA: hda: generic: Add vmaster mute LED helper
>   ALSA: hda/realtek: Use the new vmaster mute LED helper
>   ALSA: hda/conexant: Use the new vmaster mute LED helper
>   ALSA: hda/sigmatel: Use the new vmaster mute LED helper
>   ALSA: hda/realtek: Unify LED helper code
>   ALSA: hda: Let LED cdev handling suspend/resume
> 
>  sound/pci/hda/Kconfig           |   9 ++
>  sound/pci/hda/hda_generic.c     | 134 ++++++++++++-------
>  sound/pci/hda/hda_generic.h     |  13 +-
>  sound/pci/hda/patch_conexant.c  |  47 +++----
>  sound/pci/hda/patch_realtek.c   | 220 +++++++++++++++-----------------
>  sound/pci/hda/patch_sigmatel.c  |  22 ++--
>  sound/pci/hda/thinkpad_helper.c |  19 +--
>  7 files changed, 248 insertions(+), 216 deletions(-)
> 

added to oem-5.6-next, thanks


-- 
Timo Aaltonen
Senior Engineer, Kernel Enablement
Canonical Ltd.



More information about the kernel-team mailing list