ACK/Cmnt: [SRU][B/D/E/F - ALL TREES][PATCH] UBUNTU: [Packaging] Fix config file assembly
Stefan Bader
stefan.bader at canonical.com
Fri Jan 24 06:35:19 UTC 2020
On 22.01.20 09:32, Juerg Haefliger wrote:
> Commit 'UBUNTU: [Packaging] dkms -- switch to a consistent build prefix
> length and strip' introduced a helper tool fix-filenames which was added as
> a prerequisite to the $(stampdir)/stamp-prepare-tree-% rule. This rule
> generates the config file by concatenating all prereqs together
> (cat $^ ...) including the fix-filenames binary blob which results in
> warnings like:
>
> scripts/kconfig/conf --silentoldconfig Kconfig
> .config:8536:warning: unexpected data: ^?ELF^B^A^A
> .config:8073:warning: unexpected data:
> .config:8537:warning: unexpected data:
> .config:8538:warning: unexpected data:
> .config:8539:warning: unexpected data:
>
> This is certainly not what we want, fix it.
>
> Ignore: yes
> Signed-off-by: Juerg Haefliger <juergh at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---
May help others to say that basically there is a fix number of words (4) and the
last one is the one this patch eliminates away.
> debian/rules.d/2-binary-arch.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index a15d7921a682..684eaa55d40c 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -30,7 +30,7 @@ $(stampdir)/stamp-prepare-tree-%: $(commonconfdir)/config.common.$(family) $(arc
> touch $(builddir)/build-$*/ubuntu-build
> [ "$(do_full_source)" != 'true' ] && true || \
> rsync -a --exclude debian --exclude debian.master --exclude $(DEBIAN) * $(builddir)/build-$*
> - cat $^ | sed -e 's/.*CONFIG_VERSION_SIGNATURE.*/CONFIG_VERSION_SIGNATURE="Ubuntu $(release)-$(revision)-$* $(raw_kernelversion)"/' > $(builddir)/build-$*/.config
> + cat $(wordlist 1,3,$^) | sed -e 's/.*CONFIG_VERSION_SIGNATURE.*/CONFIG_VERSION_SIGNATURE="Ubuntu $(release)-$(revision)-$* $(raw_kernelversion)"/' > $(builddir)/build-$*/.config
> find $(builddir)/build-$* -name "*.ko" | xargs rm -f
> $(build_cd) $(kmake) $(build_O) -j1 syncconfig prepare scripts
> touch $@
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200124/51e4f73f/attachment.sig>
More information about the kernel-team
mailing list