ACK/Cmnt: [PATCH B/E/F OEM-B/OEM-OSP1-B 1/1] UBUNTU: SAUCE: ACPI: video: Use native backlight on Lenovo E41-25/45

[Stefan Bader]

On 14.01.20 06:47, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1859561
> 
> ACPI backlight control doesn't work on 2 Lenovo E41 laptops.
> So force to use native backlight control on them.
> 
> (cherry picked from https://patchwork.kernel.org/patch/11293665/)
> Signed-off-by: Aaron Ma <aaron.ma at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---

The bug report was missing most tasks and maybe I should just have ignored this
submission until that were fixed (to treat everyone with the same grumpyness).
But at the same time there are some other aspects to this which are helpful to
discuss, so I went ahead and cleaned up the bug report tasks.

I have set the disco task to "Won't Fix" because this is specific to certain
laptops and for that reason better suited to go into oem-osp1 (since Disco goes
EOL on Jan-23).

For Bionic: normally I would like to see only changes which have landed upstream
in a LTS tree. But this is just adding quirks for very specific laptop models,
so it would be too harsh to insist on that rule. But generally I think we should
be more conservative with those long term trees.

-Stefan

>  drivers/acpi/video_detect.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 43587ac680e4..f6add9d82fa9 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -294,6 +294,22 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "102434U"),
>  		},
>  	},
> +	{
> +	 .callback = video_detect_force_native,
> +	 .ident = "Lenovo E41-25",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "81FS"),
> +		},
> +	},
> +	{
> +	 .callback = video_detect_force_native,
> +	 .ident = "Lenovo E41-45",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "82BK"),
> +		},
> +	},
>  	{
>  	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */
>  	 .callback = video_detect_force_native,
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200116/a3ab4f19/attachment.sig>