ACK: [SRU][Bionic][PATCH 0/2] Fix ThunderX boot issues

Andrea Righi andrea.righi at canonical.com
Wed Jan 15 17:42:24 UTC 2020


On Wed, Jan 15, 2020 at 06:36:36PM +0100, Juerg Haefliger wrote:
> Two trivial KPTI patches to fix a nasty ThunderX boot issues.
> 
> The 'arm64: add sentinel to kpti_safe_list' patch might not be a
> contributor here but it certainly fixes a real issue since on ThunderX the
> list is traversed all the way to the end and not stopped due to the
> missing sentinel.
> 
> The real problem is fixed by 'arm64: Check for errata before evaluating
> cpu features'. The kernel has a check in place for a certain Cavium errata.
> If that errata is enabled, KPTI is turned off (the code comment mentions
> I-cache clobbering if both are enabled at the same time). Some earlier KPTI
> commit changed the order in which features and erratas are evaluated and
> enabled resulting in a short period of time where both KPTI and that errata
> are enabled. The fix reverses that order.
> 
> Dirk Mueller (1):
>   arm64: Check for errata before evaluating cpu features
> 
> Mark Rutland (1):
>   arm64: add sentinel to kpti_safe_list
> 
>  arch/arm64/kernel/cpufeature.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

The two patches are trivial and they look correct to me.

Acked-by: Andrea Righi <andrea.righi at canonical.com>



More information about the kernel-team mailing list