ACK/Cmnt: [SRU][B/OEM-B/OEM-OSP1/E/unstable][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek - Line-out jack doesn't work on a Dell AIO

[Kleber Souza]

On 2019-12-11 08:52, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1855999
> 
> After applying the fixup ALC274_FIXUP_DELL_AIO_LINEOUT_VERB, the
> Line-out jack works well. And instead of adding a new set of pin
> definition in the pin_fixup_tbl, we put a more generic matching entry
> in the fallback_pin_fixup_tbl.
> 
> Cc: <stable at vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang at canonical.com>
> Link: https://lore.kernel.org/r/20191211051321.5883-1-hui.wang@canonical.com
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> (cherry picked from commit 5815bdfd7f54739be9abed1301d55f5e74d7ad1f
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)

This patch has already reached Linus' tree with the same SHA1, so we can
remove the URL to sound.git repo and the 'UBUNTU: SAUCE:' tag from the
subject.

> Signed-off-by: Hui Wang <hui.wang at canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

> ---
>  sound/pci/hda/patch_realtek.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 10a3668f975d..4abe030800f7 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7617,11 +7617,6 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x1a, 0x90a70130},
>  		{0x1b, 0x90170110},
>  		{0x21, 0x03211020}),
> -	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB,
> -		{0x12, 0xb7a60130},
> -		{0x13, 0xb8a61140},
> -		{0x16, 0x90170110},
> -		{0x21, 0x04211020}),
>  	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>  		{0x12, 0x90a60130},
>  		{0x14, 0x90170110},
> @@ -7815,6 +7810,9 @@ static const struct snd_hda_pin_quirk alc269_fallback_pin_fixup_tbl[] = {
>  	SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>  		{0x19, 0x40000000},
>  		{0x1a, 0x40000000}),
> +	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB,
> +		{0x19, 0x40000000},
> +		{0x1a, 0x40000000}),
>  	{}
>  };
>  
>