ACK: [X][B][D][SRU][PATCH 0/2] Fix for efivarfs test on second run

[Colin Ian King]

On 03/01/2020 10:52, Po-Hsu Lin wrote:
> == SRU Justification ==
> If you run the test selftest/efivarfs test suite twice, it will fail on
> the second run.
> 
> This is because the test file created in the first run will obtain the
> immutable property, and it will make the second attempt failed with
> premission denied error.
> 
> == Fix ==
> * 1f0ea958 (selftests: efivarfs: return Kselftest Skip code for skipped tests)
> * dff6d2ae (selftests/efivarfs: clean up test files from test_create*())
> 
> This issue exists in X/B/D, fixed in newer releases.
> 
> For Xenial it lacks the crucial commit which allows the selftest
> framework to handle KSFT_SKIP return code (3f4435b5), so the first
> commit has to be backported to keep using 0 as its return value. The
> second commit is a backport with fuzzy adjustments.
> 
> For Bionic, the first commit is a clean cherry-pick, the second is a
> backport with fuzzy adjustments.
> 
> For Disco, it just needs the second commit, which is also a backport
> with fuzzy adjustments as well.
> 
> == Test ==
> Patch tested against the affected kernels, and it works as expected.
> 
> == Regression Potential ==
> Low, changes limited to testing tools.
> 
> Po-Hsu Lin (1):
>   selftests/efivarfs: clean up test files from test_create*()
> 
> Shuah Khan (Samsung OSG) (1):
>   selftests: efivarfs: return Kselftest Skip code for skipped tests
> 
>  tools/testing/selftests/efivarfs/efivarfs.sh | 35 ++++++++++++++--------------
>  1 file changed, 18 insertions(+), 17 deletions(-)
> 

Looks good to me. Thanks.

Acked0-by: Colin Ian King <colin.king at canonical.com>