ACK: [B][D][E][F][SRU][PATCH 0/1] Turn off timeout setting for ftrace test in kselftests

Colin Ian King colin.king at canonical.com
Mon Feb 24 16:30:22 UTC 2020


On 21/02/2020 10:21, Po-Hsu Lin wrote:
> == SRU Justification ==
> A new timeout feature was added to kselftests in commit 852c8cbf
> (selftests/kselftest/runner.sh: Add 45 second timeout per test)
> 
> However the ftrace test will take much longer than 45 seconds to run,
> thus you will see it failed with:
>    not ok 1 selftests: ftrace: ftracetest # TIMEOUT
> 
> == Fix ==
> * 9fab89cc (tracing/selftests: Turn off timeout setting)
> 
> This patch will turn off the timeout setting for the ftrace test.
> It can be cherry-picked into B/D/E/F, we don't run this test in X so it
> can be skipped.
> 
> Note that we don't have 852c8cbf in B/D, but I think it's still OK to
> fix them as the change is really small, and if they got that patch in
> the future we don't need to look back on this.
> 
> == Test ==
> Patch tested directly on KVM nodes. It works as expected.
> 
> == Regression Potential ==
> Low, trivial change limited to testing tools.
> 
> 
> Steven Rostedt (VMware) (1):
>   tracing/selftests: Turn off timeout setting
> 
>  tools/testing/selftests/ftrace/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/ftrace/settings
> 
Seems reasonable to me.

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the kernel-team mailing list