APPLIED/cmnt: [PATCH 1/1][SRU][D/E] UBUNTU: SAUCE: drm/i915: Disable PSR by default on all platforms

Kleber Souza kleber.souza at canonical.com
Fri Feb 14 10:50:24 UTC 2020


On 11.02.20 02:57, Sultan Alsawaf wrote:
> BugLink: https://bugs.launchpad.net/bugs/1849947
> 
> On all Dell laptops with screens and chipsets that support PSR, both
> PSR1 and PSR2 cause flickering and graphical glitches. Many laptops
> don't support PSR so it isn't known if PSR works correctly on any
> consumer hardware. PSR was enabled by default in 5.0 for capable
> hardware, so this patch just restores the previous functionality of PSR
> being disabled by default.
> 
> More info is available on the freedesktop bug:
> https://gitlab.freedesktop.org/drm/intel/issues/425
> 
> Signed-off-by: Sultan Alsawaf <sultan.alsawaf at canonical.com>

Applied to disco/linux (with some fuzzing) and to eoan/linux.
I also fixed the bug nominations.

Thanks,
Kleber



> ---
>  drivers/gpu/drm/i915/i915_params.c | 3 +--
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 5b07766a1c26..71953f4e019f 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -84,8 +84,7 @@ i915_param_named_unsafe(enable_hangcheck, bool, 0600,
>  
>  i915_param_named_unsafe(enable_psr, int, 0600,
>  	"Enable PSR "
> -	"(0=disabled, 1=enabled) "
> -	"Default: -1 (use per-chip default)");
> +	"(-1=use per-chip default, 0=disabled [default], 1=enabled) ");
>  
>  i915_param_named_unsafe(force_probe, charp, 0400,
>  	"Force probe the driver for specified devices. "
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index a4770ce46bd2..d0167c5f47ff 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -50,7 +50,7 @@ struct drm_printer;
>  	param(int, vbt_sdvo_panel_type, -1) \
>  	param(int, enable_dc, -1) \
>  	param(int, enable_fbc, -1) \
> -	param(int, enable_psr, -1) \
> +	param(int, enable_psr, 0) \
>  	param(int, disable_power_well, -1) \
>  	param(int, enable_ips, 1) \
>  	param(int, invert_brightness, 0) \
> 




More information about the kernel-team mailing list