ACK/cmnt: [SRU][F/E/OEM-B-OSP1][PATCH 0/2] volume control doesn't work (it's just on/off) on Lenovo ThinkPad X1 Carbon 7th gen

[Kleber Souza]

On 10.02.20 04:13, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1845677
> 
> The 1st patch is already in the oem-b-osp1 kernel, only needs to
> merge the 2nd patch.
> 
> For focal and eoan kernels, they need to merge 2 patches.
> 
> For bionic and oem-b kernels, because they don't support sof driver
> and these 2 machines are dmic machines, so no need to merge these 2
> patches.
> 
> [Impact]
> There are 2 physical speakers on the X1 7th, and one is Bass speaker
> and connect to a DAC which doesn't have volume control on it.
> 
> [Fix]
> adjust that speaker to connect to a DAC which has volume control
> capability.
> 
> 
> [Test Case]
> adjust the output volume from UI and play sound from speaker.
> 
> 
> [Regression Risk]
> Low, these change is specific to 2 lenovo machines.
> 
> 
> Jaroslav Kysela (1):
>   ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen
> 
> Kailang Yang (1):
>   ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1
>     7th gen
> 
>  sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 

Clean cherry-picks.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>


Hui, can you please fix the nominations on the bug report?

Thank you.