[SRU][D / B aws-edge][aws][PULL v2] proper hibernation support
Andrea Righi
andrea.righi at canonical.com
Tue Feb 11 07:22:42 UTC 2020
On Mon, Feb 10, 2020 at 03:24:12PM -0500, Khaled Elmously wrote:
> I can't say much about the correctness of the code-changes, however:
> - There are commits in the pull that don't have BugLinks. Though a BugLink (to LP #1831940? Or should it be 1858618?) can be added when applying
> - A few of the commits already have ACKs. Some have 2 ACKs. How did that happen? Do those commits need to be reviewed again?
> - At least one commit appears to be neither an upstream patch nor a SAUCE patch. Usually for a commit to be accepted it needs to be one of those.
Thanks for the review, Khaled. About the commits that already have ACKs,
the reason is because I ported them from the bionic kernel and didn't
remove the Acked-by lines. I'll send a new pull request adding all the
missing information.
-Andrea
More information about the kernel-team
mailing list