[PATCH 257/379][SRU][OEM-5.6] ath11k: Fix possible memleak in ath11k_qmi_init_service

You-Sheng Yang vicamo.yang at canonical.com
Wed Dec 23 08:49:50 UTC 2020


From: Wang Yufen <wangyufen at huawei.com>

BugLink: https://bugs.launchpad.net/bugs/1879633

When qmi_add_lookup fail, we should destroy the workqueue

Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Wang Yufen <wangyufen at huawei.com>
Signed-off-by: Kalle Valo <kvalo at codeaurora.org>
Link: https://lore.kernel.org/r/1595237804-66297-1-git-send-email-wangyufen@huawei.com
(cherry picked from commit 28f1632118818d9dccabf4c0fccfe49686742317)
Signed-off-by: You-Sheng Yang <vicamo.yang at canonical.com>
---
 drivers/net/wireless/ath/ath11k/qmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index b81897131f0a..91134510364c 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -2648,6 +2648,7 @@ int ath11k_qmi_init_service(struct ath11k_base *ab)
 			     ab->qmi.service_ins_id);
 	if (ret < 0) {
 		ath11k_warn(ab, "failed to add qmi lookup\n");
+		destroy_workqueue(ab->qmi.event_wq);
 		return ret;
 	}
 
-- 
2.29.2




More information about the kernel-team mailing list