[OEM-5.6][SRU][PATCH 0/1] selftests: fib_nexthop_multiprefix: fix cleanup() netns deletion

Po-Hsu Lin po-hsu.lin at canonical.com
Fri Dec 18 03:21:56 UTC 2020


[Impact]
The incorrect cleanup() in fib_nexthop_multiprefix.sh will cause
failure to this script even if the test itself has passed.

$ sudo ./fib_nexthop_multiprefix.sh
TEST: IPv4: host 0 to host 1, mtu 1300                              [ OK ]
TEST: IPv6: host 0 to host 1, mtu 1300                              [ OK ]

TEST: IPv4: host 0 to host 2, mtu 1350                              [ OK ]
TEST: IPv6: host 0 to host 2, mtu 1350                              [ OK ]

TEST: IPv4: host 0 to host 3, mtu 1400                              [ OK ]
TEST: IPv6: host 0 to host 3, mtu 1400                              [ OK ]

TEST: IPv4: host 0 to host 1, mtu 1300                              [ OK ]
TEST: IPv6: host 0 to host 1, mtu 1300                              [ OK ]

TEST: IPv4: host 0 to host 2, mtu 1350                              [ OK ]
TEST: IPv6: host 0 to host 2, mtu 1350                              [ OK ]

TEST: IPv4: host 0 to host 3, mtu 1400                              [ OK ]
TEST: IPv6: host 0 to host 3, mtu 1400                              [ OK ]
$ echo $?
1

[Fix]
* 651149f6037675 ("selftests: fib_nexthop_multiprefix: fix cleanup()
netns deletion")

This has already been applied to all the other generic kernels via
stable update (bug 1891063)

[Test case]
Run this script and the return value will be 0

[Where problems could occur]
As it's just fixing the cleanup to make it match with setup(), it's
unlikely to see bad things to happen here.


Paolo Pisati (1):
  selftests: fib_nexthop_multiprefix: fix cleanup() netns deletion

 tools/testing/selftests/net/fib_nexthop_multiprefix.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4




More information about the kernel-team mailing list