[PATCH 0/1][SRU][F][G][unstable][OEM-5.10] Stop using get_scalar_status command in Dell AIO uart backlight driver Edit

AceLan Kao acelan.kao at canonical.com
Thu Dec 17 08:08:57 UTC 2020


From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1865402

[Impact]
The get_scalar_status command was provided by ODM engineer and was newly
introduced to determinate whether scalar is responsible for the backlight
adjustment. That guy asked the scalar vendor to add this command and the
command works as expected. But there is already a command in the Dell AIO
scalar UART command spec. which can do the same thing since 2015, and the
newly introduced get_scalar_status command is undocumented. To prevent
from introducing regression in the future and to align with what Windows
uses, replace this command with get_display_mode command.

[Fix]
Replace get_scalar_status command with get_display_mode command.

[Test]
Verified on new Dell AIO platforms.

[Regression Potential]
Low, the command is already in the spec. since 2015.

Chia-Lin Kao (AceLan) (1):
  UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add get_display_mode
    command

 drivers/platform/x86/dell-uart-backlight.c | 91 +++++++++++-----------
 drivers/platform/x86/dell-uart-backlight.h |  7 +-
 2 files changed, 52 insertions(+), 46 deletions(-)

-- 
2.25.1




More information about the kernel-team mailing list