ACK/Cmnt: [PATCH 0/3][SRU][F/G/H/U/OEM-5.6] Fix i2c report error on elan trackpoint

[Stefan Bader]

On 16.12.20 06:12, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908335
> 
> [Impact]
> New elan trackpoint on elan_i2c reports the following error:
> "failed to read report data: -71"
> it failed to work.
> 
> [Fix]
> Add new report type support and fix protocol errors for some trackpoints
> in SMBus mode.
> 
> [Test Case]
> Touchpad and trackpoint work well.
> 
> [Where problems could occur]
> elan touchpad and trackpoint may not work.
> 
> Jingle Wu (2):
>   Input: elan_i2c - add support for high resolution reports
>   UBUNTU: SAUCE: Input: elan_i2c - add new trackpoint report type 0x5F
> 
> jingle.wu (1):
>   UBUNTU: SAUCE: Input: elantech - fix protocol errors for some
>     trackpoints in SMBus mode
> 
>  drivers/input/mouse/elan_i2c.h       |  24 ++++-
>  drivers/input/mouse/elan_i2c_core.c  | 133 ++++++++++++++++-----------
>  drivers/input/mouse/elan_i2c_i2c.c   |  34 +++++--
>  drivers/input/mouse/elan_i2c_smbus.c |  25 ++++-
>  drivers/input/mouse/elantech.c       |  99 +++++++++++++++++++-
>  drivers/input/mouse/elantech.h       |   4 +
>  6 files changed, 247 insertions(+), 72 deletions(-)
> 
Things like having done additional tesing on older hardware with the same driver
would be good to have in the test section of the bug report. It helps to get
more confidence in the changes.

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20201216/684bc6cb/attachment.sig>