ACK/cmnt: [F/G/H/Unstable][SRU][PATCH] selftests: test_vxlan_under_vrf: mute unnecessary error message

[Kleber Souza]

On 16.12.20 10:39, Po-Hsu Lin wrote:
> On Wed, Dec 16, 2020 at 5:18 PM Kleber Souza <kleber.souza at canonical.com> wrote:
>>
>> On 16.12.20 05:22, Po-Hsu Lin wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1908342
>>>
>>> The cleanup function in this script that tries to delete hv-1 / hv-2
>>> vm-1 / vm-2 netns will generate some uncessary error messages:
>>>
>>> Cannot remove namespace file "/run/netns/hv-2": No such file or directory
>>> Cannot remove namespace file "/run/netns/vm-1": No such file or directory
>>> Cannot remove namespace file "/run/netns/vm-2": No such file or directory
>>>
>>> Redirect it to /dev/null like other commands in the cleanup function
>>> to reduce confusion.
>>>
>>> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
>>> Link: https://lore.kernel.org/r/20201211042420.16411-1-po-hsu.lin@canonical.com
>>> Signed-off-by: Jakub Kicinski <kuba at kernel.org>
>>> (cherry picked from commit 0e12c0271887f1b00b79b7612c1d4f0d3d34e8a8)
>>
>> This patch hasn't hit mainline yet, so we should add "linux-next" after the sha1
>> on the "cherry picked" line above if this is still true when applying the patch.
>>
> Hello Kleber,
> 
> Thanks for the review, I can see this one in Linus's tree
> https://github.com/torvalds/linux/commit/0e12c0271887f1b00b79b7612c1d4f0d3d34e8a8

Hi Sam,

You are right, I missed the patch there. So no change is needed.

Sorry for the noise.

Thanks,
Kleber

> 
> So I guess it should be fine?
> Sam
> 
>>> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
>>
>> Otherwise it looks good.
>>
>> Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
>>
>>> ---
>>>    tools/testing/selftests/net/test_vxlan_under_vrf.sh | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/net/test_vxlan_under_vrf.sh b/tools/testing/selftests/net/test_vxlan_under_vrf.sh
>>> index 60442ad..9b919ac 100755
>>> --- a/tools/testing/selftests/net/test_vxlan_under_vrf.sh
>>> +++ b/tools/testing/selftests/net/test_vxlan_under_vrf.sh
>>> @@ -50,7 +50,7 @@ cleanup() {
>>>        ip link del veth-tap 2>/dev/null || true
>>>
>>>        for ns in hv-1 hv-2 vm-1 vm-2; do
>>> -        ip netns del $ns || true
>>> +        ip netns del $ns 2>/dev/null || true
>>>        done
>>>    }
>>>
>>>
>>