ACK/cmnt: [SRU][G,H][PATCH 0/3] disable building bpf selftests
Kleber Souza
kleber.souza at canonical.com
Tue Dec 15 10:08:09 UTC 2020
On 14.12.20 23:00, Kamal Mostafa wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908144
>
> Building tools/testing/selftests/bpf/ requires dependencies which cannot
> be easily satisfied by our build process. The problem is well-described
> by the pending upstream patch:
>
> https://lore.kernel.org/bpf/20201210185233.28091-1-broonie@kernel.org/
> From: Mark Brown <broonie at kernel.org>
> Subject: [PATCH] selftests: Skip BPF seftests by default
>
> To effect the same for {groovy, hirsute} we must instead make a
> debian/rules change via "UBUNTU: disable building bpf selftests (no
> VMLINUX_BTF)".
>
> But lets also pick up the upstream change above, as well as my related
> "clarify" change, also pending upstream.
>
> These three patches should be applied to {groovy, hirsute}:
>
> UBUNTU: SAUCE: selftests/bpf: clarify build error if no vmlinux
> UBUNTU: SAUCE: selftests: Skip BPF seftests by default
> UBUNTU: disable building bpf selftests (no VMLINUX_BTF)
>
> -Kamal
>
> ---
>
> Kamal Mostafa (2):
> UBUNTU: SAUCE: selftests/bpf: clarify build error if no vmlinux
> UBUNTU: disable building bpf selftests (no VMLINUX_BTF)
>
> Mark Brown (1):
> UBUNTU: SAUCE: selftests: Skip BPF seftests by default
>
> debian/rules.d/0-common-vars.mk | 2 +-
> tools/testing/selftests/Makefile | 6 ++++--
> tools/testing/selftests/bpf/Makefile | 3 +++
> 3 files changed, 8 insertions(+), 3 deletions(-)
>
bpf selftests will be prone again to build breakage detected only after
the kernels are already built, but I also don't see a better solution
for now.
Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
More information about the kernel-team
mailing list