APPLIED[U]: [SRU] [Unstable/OEM-5.10] [PATCH 0/3] Drop i915 PSR workarounds

Andrea Righi andrea.righi at canonical.com
Tue Dec 15 08:20:44 UTC 2020


On Wed, Dec 09, 2020 at 01:13:51AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1907285
> 
> [Impact]
> Disabling PSR helps some platforms but breaks others. So let's not play
> this whack-a-mole game.
> 
> In addition to that, PSR can provide significant power saving, let Intel
> SoC reach PC10 or even SLP_S0 withouth turning screen off.
> 
> [Fix]
> Drop PSR workaround and stick to upstream code.
> 
> [Test]
> Monitor numbers in /sys/kernel/debug/pmc_core/*
> 
> With PSR enabled, some Tiger Lake laptops can reach SLP_S0 without
> turning screen off.
> 
> [Regression Potential]
> Panels that don't work well with PSR may break again. If that ever
> happens, we can introduce a blacklist on panels.
> 
> Kai-Heng Feng (3):
>   Revert "UBUNTU: SAUCE: drm/dp: add DP_QUIRK_FORCE_PSR_CHIP_DEFAULT
>     quirk to CMN prod-ID 19-15"
>   Revert "UBUNTU: SAUCE: drm/i915/psr: allow overriding PSR disable
>     param by quirk"
>   Revert "UBUNTU: SAUCE: drm/i915: Disable PSR by default on all
>     platforms"
> 
>  drivers/gpu/drm/drm_dp_helper.c          | 5 -----
>  drivers/gpu/drm/i915/display/intel_psr.c | 8 --------
>  drivers/gpu/drm/i915/i915_params.c       | 3 ++-
>  drivers/gpu/drm/i915/i915_params.h       | 2 +-
>  include/drm/drm_dp_helper.h              | 8 --------
>  5 files changed, 3 insertions(+), 23 deletions(-)

Applied to unstable. Thanks!

-Andrea



More information about the kernel-team mailing list