APPLIED/cmt: [PATCH v2 0/1][SRU][linux-firmware][F] Support Intel AX210 wifi

[Seth Forshee]

On Fri, Dec 04, 2020 at 05:19:18PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1902848
> 
> [Impact]
> 
> To support next generation of Intel AX210 WiFi family. PCI ID
> [8086:2725] Subsystem [8086:4020] specifically.
> 
> So far only patchset
> https://lore.kernel.org/linux-wireless/20201202124151.55050-1-luca@coelho.fi
> is required on v5.10-rc6, and itself is also in mainline kernel for
> v5.10-rc7 at this moment. To enable this card with oem-5.10 kernel in
> Focal, firmware blob is also required and hence SRU sent.
> 
> [Fix]
> 
> Firmware iwlwifi-ty-a0-gf-a0-59.ucode from commit 4f41e9d6437d ("iwlwifi:
> update and add new FWs from core56-54 release").
> 
> [Test Case]
> 
> 1. Boot with kernel from mainline tip or v5.10-rc7 or newer.
> 2. Check with `sudo dmesg | grep iwlwifi`.
> 
> [Where problems could occur]
> 
> New device firmware for initial AX210 hardware support. Very unlikely to
> have any issue.

I think it may get confusing if we frequently pull in a single file from
an upstream commit yet in the changelog it looks like a cherry pick of
the entire commit. So I've modified the commit log to make it a sauce
patch which indicates what upstream the commit the firmware was taken
from without saying (backported from ...).

I also find your "Where problems could occur" statement somewhat
lacking. For example, the firmware could crash for users which have
kernel/hardware combinations which will use the firmware. But without
the file the users would have no support for their hardware at all, so
that risk is justified.

I've applied this with the commit message changes, but please update the
bug to give a more complete assessment of the risks.

Thanks,
Seth

> 
> Luca Coelho (1):
>   iwlwifi: update and add new FWs from core56-54 release
> 
>  WHENCE                       |   3 +++
>  iwlwifi-ty-a0-gf-a0-59.ucode | Bin 0 -> 1413868 bytes
>  2 files changed, 3 insertions(+)
>  create mode 100644 iwlwifi-ty-a0-gf-a0-59.ucode
> 
> -- 
> 2.29.2
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team