APPLIED[F]/NAK[B]/CMT: [SRU][B][F][PATCH 0/1] kernel: s390/cpum_cf, perf: change DFLT_CCERROR counter name (LP: 1891454)
Stefan Bader
stefan.bader at canonical.com
Fri Aug 28 06:35:31 UTC 2020
On 28.08.20 08:00, Frank Heimes wrote:
> Hi Kelsey,
> well, that worked for me when I did that in preparation for this SRU two days
> ago (incl. Kernel compile) and it worked now again - with the very latest bionic
> master-next tree.
>
> user at workstation:~/ubuntu-bionic-master-next/bionic-lp1$ cd
> ~/ubuntu-bionic-master-next/
> user at workstation:~/ubuntu-bionic-master-next$ cd bionic-clean/
> user at workstation:~/ubuntu-bionic-master-next/bionic-clean$ git pull origin
> master-next
> ...
> user at workstation:~/ubuntu-bionic-master-next/bionic-clean$ wget -P ~
> https://launchpadlibrarian.net/493439681/u18-0001-s390-cpum_cf-Add-new-extended-counters-for-IBM-z15.patch
> ...
> user at workstation:~/ubuntu-bionic-master-next/bionic-clean$ git am
> /home/user/u18-0001-s390-cpum_cf-Add-new-extended-counters-for-IBM-z15.patch
> Applying: s390/cpum_cf: Add new extended counters for IBM z15
> user at workstation:~/ubuntu-bionic-master-next/bionic-clean$ git log
> --pretty=oneline --abbrev-commit --decorate -n 2
> 42e230e29575 (HEAD -> master-next) s390/cpum_cf: Add new extended counters for
> IBM z15
> d91102d61d27 (origin/master-next) UBUNTU: [packaging] add signed modules for
> nvidia 450 and 450-server
> user at workstation:~/ubuntu-bionic-master-next/bionic-clean$
>
> But I now see the issue.
> I 'think' that the backport for focal was used for bionic.
> Please notice that there are two different backports for this
> sRU: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1891454 "[Fix]
> section" - one for focal and one for bionic.
> But with this submission I only sent over the one for focal - and only
> referenced the backport for bionic in the Justification...
>
> So I guess it's best if I now submit a v2 just dealing with bionic ...
If you do not send individual patches with the sru submission they do not exist.
Don't expect us to hunt chase down bug reports to pick up pieces of it.
-Stefan
>
> Bye, Frank
>
> irc: jfh -- ubuntu-on-big-iron.blogspot.com
> <http://ubuntu-on-big-iron.blogspot.com/?view=sidebar>
>
>
> On Fri, Aug 28, 2020 at 7:09 AM Frank Heimes <frank.heimes at canonical.com
> <mailto:frank.heimes at canonical.com>> wrote:
>
> Hi Kelsey, thanks for coming back on this - I will investigate ...
>
>
> irc: jfh -- ubuntu-on-big-iron.blogspot.com
> <http://ubuntu-on-big-iron.blogspot.com/?view=sidebar>
>
>
> On Fri, Aug 28, 2020 at 7:02 AM Kelsey Skunberg
> <kelsey.skunberg at canonical.com <mailto:kelsey.skunberg at canonical.com>> wrote:
>
> Hi Frank! This has been applied to focal master-next.
>
> For Bionic, the patch does not apply since the commit "extended counters
> for IBM z15" is not currently in bionic master-next. I see that patch
> was SRU'd for focal, though not bionic. May you please send a v2 for
> just bionic which includes the needed patches? Thanks so much!
>
> -Kelsey
>
> On 2020-08-25 15:53:33 , frank.heimes at canonical.com
> <mailto:frank.heimes at canonical.com> wrote:
> > Buglink: https://bugs.launchpad.net/bugs/1891454
> >
> > SRU Justification:
> >
> > [Impact]
> >
> > * Change the counter name DLFT_CCERROR to DLFT_CCFINISH on IBM z15 to
> avoid confusion.
> >
> > * This counter counts completed DEFLATE instructions with exit code 0,
> 1 or 2.
> >
> > * And since exit code 0 means success and exit code 1 or 2 indicate
> errors the name can be ambiguous.
> >
> > [Fix]
> >
> > * Rename s390 z15 counter named DFLT_CCERROR to DFLT_CCFINISH.
> >
> > * Backport Focal:
> https://launchpadlibrarian.net/493272507/0001-s390-cpum_cf-perf-change-DFLT_CCERROR-counter-name.patch
> >
> > * Backport Bionic:
> https://launchpadlibrarian.net/493439681/u18-0001-s390-cpum_cf-Add-new-extended-counters-for-IBM-z15.patch
> >
> > [Test Case]
> >
> > * Enable hardware counters in the activation profile of a z15 LPAR.
> >
> > * Just check the countername in sysfs with: ls
> /sys/devices/cpum_cf/events/{DFLT_CCERROR,DFLT_CCFINISH}
> >
> > [Regression Potential]
> >
> > * The regression potential can be considered as low, since:
> >
> > * Counters like these are usually not activated by default and need to
> be explicitly enabled.
> >
> > * No code functionality is changed with that patch, only a renaming is
> done at 3 places in one code file arch/s390/kernel/perf_cpum_cf_events.c
> as well as in /tools/perf/pmu-events/arch/s390/cf_z15/extended.json.
> >
> > * The fix got already upstream accepted in 5.8-rc7, hence it got
> upstream reviewed,
> >
> > * and the modifications are limited to s390x, are only relevant for
> the z15 / LinuxONE III hw generation that are relatively new.
> >
> > * Issue with the renaming I can think of are that people don't know
> about the new name and may look for the old one and don't find it anymore,
> >
> > * and with that also if the old counter name is used in scripts or
> applications, these may fails due to an unknown counter name.
> >
> > [Other Info]
> >
> > * The backports are based on commit
> 3d3af181d370069861a3be94608464e2ff3682e2 ("s390/cpum_cf,perf: change
> DFLT_CCERROR counter name") that is upstream accepted since v5.8-rc7.
> >
> > * Hence this SRU is not requested for groovy, since it's already in
> groovys kernel 5.8 in proposed, but only requested for focal and bionic.
> >
> > Thomas Richter (1):
> > s390/cpum_cf,perf: change DFLT_CCERROR counter name
> >
> > arch/s390/kernel/perf_cpum_cf_events.c | 4 ++--
> > tools/perf/pmu-events/arch/s390/cf_z15/extended.json | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > --
> > 2.25.1
> >
> >
> > --
> > kernel-team mailing list
> > kernel-team at lists.ubuntu.com <mailto:kernel-team at lists.ubuntu.com>
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200828/552aebae/attachment.sig>
More information about the kernel-team
mailing list