NACK: [PATCH 1/1] [B/Aws-5.4 V2][L-R-M] UBUNTU: [packaging] replace nvidia 440 with nvidia 450 driver

[Stefan Bader]

On 21.08.20 18:30, Alberto Milone wrote:
> Replace the 440 series with the 440 series and add
> transitional packages.
> 
> BugLink: https://bugs.launchpad.net/bugs/1887674
> 
> Signed-off-by: Alberto Milone <alberto.milone at canonical.com>
> ---
>  debian/dkms-versions            | 2 +-
>  debian/rules                    | 2 +-
>  debian/rules.d/2-binary-arch.mk | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/debian/dkms-versions b/debian/dkms-versions
> index 6873db2dad13..b016113d4673 100644
> --- a/debian/dkms-versions
> +++ b/debian/dkms-versions
> @@ -1,7 +1,7 @@
>  zfs-linux 0.8.3-1ubuntu12.2
>  nvidia-graphics-drivers-390 390.138-0ubuntu0.20.04.1
>  nvidia-graphics-drivers-435 435.21-0ubuntu7
> -nvidia-graphics-drivers-440 440.100-0ubuntu0.20.04.1
> +nvidia-graphics-drivers-450 0
>  nvidia-graphics-drivers-418-server 418.152.00-0ubuntu0.20.04.1
>  nvidia-graphics-drivers-440-server 440.95.01-0ubuntu0.20.04.1
>  virtualbox 6.1.10-dfsg-1~ubuntu1.20.04.1
> diff --git a/debian/rules b/debian/rules
> index 60d9496fc0c3..8bfa5f37549f 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -127,7 +127,7 @@ do_any_tools=$(sort $(filter-out false,$(do_linux_tools) $(do_cloud_tools)))
>  dkms_zfs_linux_version=$(shell gawk '/^zfs-linux / { print $$2; }' debian/dkms-versions)
>  dkms_nvidia_390_version=$(shell gawk '/^nvidia-graphics-drivers-390 / { print $$2; }' debian/dkms-versions)
>  dkms_nvidia_435_version=$(shell gawk '/^nvidia-graphics-drivers-435 / { print $$2; }' debian/dkms-versions)
> -dkms_nvidia_440_version=$(shell gawk '/^nvidia-graphics-drivers-440 / { print $$2; }' debian/dkms-versions)
> +dkms_nvidia_450_version=$(shell gawk '/^nvidia-graphics-drivers-450 / { print $$2; }' debian/dkms-versions)
>  dkms_nvidia_418_server_version=$(shell gawk '/^nvidia-graphics-drivers-418-server / { print $$2; }' debian/dkms-versions)
>  dkms_nvidia_440_server_version=$(shell gawk '/^nvidia-graphics-drivers-440-server / { print $$2; }' debian/dkms-versions)
>  dkms_vbox_guest_version=$(shell gawk '/^virtualbox/ { print $$2; }' debian/dkms-versions)
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index 6aedd68e9ce8..f845afecea58 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -405,7 +405,7 @@ endif
>  ifeq ($(do_dkms_nvidia),true)
>  	$(call build_dkms, $(bldinfo_pkg_name)-$*, $(pkgdir_bldinfo)/usr/lib/linux/$(abi_release)-$*/signatures, "", nvidia-390, pool/restricted/n/nvidia-graphics-drivers-390/nvidia-kernel-source-390_$(dkms_nvidia_390_version)_$(arch).deb pool/restricted/n/nvidia-graphics-drivers-390/nvidia-dkms-390_$(dkms_nvidia_390_version)_$(arch).deb)
>  	$(call build_dkms, $(bldinfo_pkg_name)-$*, $(pkgdir_bldinfo)/usr/lib/linux/$(abi_release)-$*/signatures, "", nvidia-435, pool/restricted/n/nvidia-graphics-drivers-435/nvidia-kernel-source-435_$(dkms_nvidia_435_version)_$(arch).deb pool/restricted/n/nvidia-graphics-drivers-435/nvidia-dkms-435_$(dkms_nvidia_435_version)_$(arch).deb)
> -	$(call build_dkms, $(bldinfo_pkg_name)-$*, $(pkgdir_bldinfo)/usr/lib/linux/$(abi_release)-$*/signatures, "", nvidia-440, pool/restricted/n/nvidia-graphics-drivers-440/nvidia-kernel-source-440_$(dkms_nvidia_440_version)_$(arch).deb pool/restricted/n/nvidia-graphics-drivers-440/nvidia-dkms-440_$(dkms_nvidia_440_version)_$(arch).deb)
> +	$(call build_dkms, $(bldinfo_pkg_name)-$*, $(pkgdir_bldinfo)/usr/lib/linux/$(abi_release)-$*/signatures, "", nvidia-450, pool/restricted/n/nvidia-graphics-drivers-450/nvidia-kernel-source-450_$(dkms_nvidia_450_version)_$(arch).deb pool/restricted/n/nvidia-graphics-drivers-450/nvidia-dkms-450_$(dkms_nvidia_450_version)_$(arch).deb)
>  endif
> 
>  ifeq ($(do_dkms_nvidia_server),true)
> --
> 2.25.1
> 
> 
 Should be done in main kernel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200824/c8176a64/attachment-0001.sig>