APPLIED[G]: [PATCH 0/1][SRU][FOCAL][GROOVY] tcp: correct read of TFO keys on big endian systems

Seth Forshee seth.forshee at canonical.com
Fri Aug 14 19:57:53 UTC 2020


On Tue, Aug 11, 2020 at 05:01:39PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1869134
> 
> == SRU Justification Focal, Groovy ==
> 
> Running the tcp_fastopen_backup_key.sh from net in ubuntu_kernel_selftests
> fails on little endian systems. This is a regression that occurred because
> of commit 438ac88009bc ("net: fastopen: robustness and endianness fixes
> for SipHash"). 
> 
> == Fix ==
> 
> Upstream (linux-next) fix:
> 
>   commit f19008e676366c44e9241af57f331b6c6edf9552
>   Author: Jason Baron <jbaron at akamai.com>
>   Date:   Mon Aug 10 13:38:39 2020 -0400
> 
>       tcp: correct read of TFO keys on big endian systems
> 
> == Test case ==
> 
> Run the kernel self tests tcp_fastopen_backup_key.sh.  Currently this fails
> on the last few test cases.  With the fix the test passes.
> 
> == Regression Potential == 
> 
> This fix touches the tcp fast open code paths so it can potentially impact
> TCP fast opening and perhaps the TCP opening. However, this has been tested
> on big and little endian systems with the regression tests, so the
> regression risk is low with this fix.

Applied to groovy/master-next, thanks!



More information about the kernel-team mailing list