NACK: ACK/cmt: [BIONIC/linux-raspi2][PATCH] mtd: nand: bcm2835-smi-nand: Pass a nand_chip object to nand_release()

[Juerg Haefliger]

Probably too late, but...


> Looks good, thanks. I would just change the title from:

That's not a 'would', it's a 'must'. Patches not originating from upstream need
to be prefixed with 'UBUNTU: SAUCE:'

 
> "mtd: nand: bcm2835-smi-nand: Pass a nand_chip object to nand_release()"
> 
> to
> 
> "UBUNTU: SAUCE: mtd: nand: bcm2835-smi-nand: Pass a nand_chip object to nand_release()"
> 
> 
> 
> 
> 
> 
> On 2020-08-13 15:34:00 , William Breathitt Gray wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1886710
> > 
> > The nand_release() function takes a nand_chip object instead of a
> > mtd_info one.

Hrm. Why? When was this introduced? How did we end up in this situation? That
needs to be spelled out in the commit message otherwise we'll have no idea
what's going on. Needless to say that nobody will remember why this is needed
in a few weeks from now. Rather provide too much information in the commit
message than none at all ;-)

...Juerg


> > Signed-off-by: William Breathitt Gray <william.gray at canonical.com>
> > ---
> >  drivers/mtd/nand/bcm2835_smi_nand.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/bcm2835_smi_nand.c b/drivers/mtd/nand/bcm2835_smi_nand.c
> > index c4826ea1c2ba..4962cc743439 100644
> > --- a/drivers/mtd/nand/bcm2835_smi_nand.c
> > +++ b/drivers/mtd/nand/bcm2835_smi_nand.c
> > @@ -222,7 +222,7 @@ static int bcm2835_smi_nand_probe(struct platform_device *pdev)
> >  	if (!ret)
> >  		return 0;
> >  
> > -	nand_release(mtd);
> > +	nand_release(mtd_to_nand(mtd));
> >  	return -EINVAL;
> >  }
> >  
> > @@ -230,7 +230,7 @@ static int bcm2835_smi_nand_remove(struct platform_device *pdev)
> >  {
> >  	struct bcm2835_smi_nand_host *host = platform_get_drvdata(pdev);
> >  
> > -	nand_release(&host->mtd);
> > +	nand_release(mtd_to_nand(&host->mtd));
> >  
> >  	return 0;
> >  }
> > -- 
> > 2.25.1
> > 
> > 
> > -- 
> > kernel-team mailing list
> > kernel-team at lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team  
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200814/0b412f71/attachment-0001.sig>