ACK/Cmnt: [SRU][Focal][OEM-5.6][PATCH 0/1] ASoC:amd:renoir: the dmic can't record sound after suspend and resume

[Stefan Bader]

On 04.08.20 04:03, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1890220
> 
> Because our OEM project is waiting for this fix, let me submit it to
> OEM-5.6 and focal kernel. for groovy kernel, the patch will be merged
> to G kernel with stable patches.
> 
> [Impact]
> We have backported the amd renoir audio driver to oem-5.6 and focal
> kernel, recently we found if the dmic is working and we suspend and
> resume, the dmic can't record the sound after resume.
> 
> [Fix]
> After resuming, the driver needs to restore 2 more registers, then the
> dmic could record the sound.
> 
> [Test Case]
> Boot the kernel with this patch, open the sound-setting and run suspend
> and resume, then use arecord to record the sound, verify the sound is
> successfully recorded by aplaying it.
> 
> [Regression Risk]
> Low, this patch is verified on the amd renoir machine, and this patch
> got ack from AMD engineer.

See https://wiki.ubuntu.com/StableReleaseUpdates/#SRU_Bug_Template about what
the SRU team would expect to see about regression potential.

> 
> 
> 
> Hui Wang (1):
>   UBUNTU: SAUCE: ASoC: amd: renoir: restore two more registers during
>     resume
> 
>  sound/soc/amd/renoir/acp3x-pdm-dma.c | 29 +++++++++-------------------
>  1 file changed, 9 insertions(+), 20 deletions(-)
> 

I am not completely happy with a patch pulled from some place and applied to a
stable release (even a LTS). I this case its isolated to a SOC driver which
worst case breaks audio on a specific platform. So with some grudge...

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200804/d2768a54/attachment-0001.sig>