NAK: [SRU][U][PATCH 0/8] Fix TC port in legacy/static mode can't be detected due TCCOLD
seth.forshee at canonical.com
Thu Apr 30 21:29:32 UTC 2020
On Wed, Apr 22, 2020 at 03:04:12PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1868936
> External monitor connected via a Type-C dongle when device is in PC10 may not be
> light up.
> Patches series https://patchwork.freedesktop.org/series/75941/ from
> intel-gfx mailing list, which has been merged in drm-tip tree with tip
> commit 0f8925090ac7.
> [Test Case]
> 1. Ensure device may enter PC10.
> $ sudo powertop --auto-tune
> $ sudo watch cat /sys/kernel/debug/pmc_core/package_cstate_show
> Press Meta+L to lock screen for a while and unlock again, "Package
> C10" field should have non-zero counts.
> 2. Press Meta+L to lock screen again.
> 3. After screen turns black and wait a few more seconds, connect external
> monitor to a type C port via a type C dongle and wake the device.
> 4. Check if external monitor is also light up as an extended/mirrored
> [Regression Potential]
The patches are okay for unstable, however there are some problems with
your submission. Primarily these lines:
(backported from drm-tip commit ...)
If you are going to add text to these lines, it must come after the
sha1. We have scripts which look for the '(cherry picked|backported)
from commit' strings, and if you add text in the middle it breaks these
Also note that if these patches were only coming from a maintainer tree,
they should be sauce. However I see these patches in linux-next, so
please denote them like this:
(backported from commit ... linux-next)
More information about the kernel-team