NACK/Cmnt: [PATCH linux-meta-kvm] control.d: specify correct wireguard placeholder in Provides

[Stefan Bader]

On 25.04.20 02:50, Jason A. Donenfeld wrote:
> In [1], apw fixed what he referred to as a "brown paperbag mistake", the
> issue being that the placeholder was named incorrectly for the
> programatically generated Provides line for wireguard. This resulted in
> the kernel package being installed without providing wireguard-modules.
> This effect then cascaded into the wireguard metapackage thinking that
> it should install wireguard-dkms, which then fails because wireguard is
> already there, and chaos ensued.
> 
> Unfortunately, [1] was never ported to linux-meta-kvm, which means that
> lots of cloud instances (such as those from Scaleway) ship broken. This
> commit simply applies the same change as [1] to the linux-meta-kvm
> package.
> 
> [1] https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux-meta/+git/focal/commit/?id=204fb3b2ae6b0c8c41c339f47949b45d571c4953
> 
> Signed-off-by: Jason A. Donenfeld <Jason at zx2c4.com>
> ---
> I haven't tested this, and I don't know if other repositories would
> benefit from having the [1] ported over, but it seems like looking into
> that would be a good next step for whoever applies this patch. It'd be
> nice to get a kernel cranked and SRU'd before too many user bug reports
> clog my inbox.
> 
>  debian/control.d/kvm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/control.d/kvm b/debian/control.d/kvm
> index 2c6d151..b111709 100644
> --- a/debian/control.d/kvm
> +++ b/debian/control.d/kvm
> @@ -9,7 +9,7 @@ Description: Linux kernel headers for virtual systems.
>  Package: linux-image-kvm${variant:suffix}
>  Architecture: amd64
>  Section: metapackages
> -Provides: ${dkms:zfs-modules} ${dkms:virtualbox-guest-modules} ${dkms:wireguard-modules}
> +Provides: ${dkms:zfs-modules} ${dkms:virtualbox-guest-modules} ${dkms:wireguard-linux-compat-modules}
>  Depends: ${misc:Depends}, linux-image-${kernel-abi-version}-kvm
>  Description: Linux kernel image for virtual systems.
>   This package will always depend on the latest kernel image available
> 
We are going to fix this up between cycles for all of the kernels derived from
focal main kernel. So NACKing this kvm only submission to avoid confusion.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200428/d98fc784/attachment-0001.sig>