ACK: [PATCH 0/2][E/F/Unstable] Move virtualbox guest modules back to linux-modules

[Andrea Righi]

On Mon, Apr 27, 2020 at 04:50:27PM -0500, Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1873506
> 
> == SRU Justification ==
> 
> Impact: When our kernel packaging was updated to build the virtualbox
> guest packages by downloading the dkms package, the modules were
> accidentally placed in linux-modules-extra instead of linux-modules.
> This has caused the modules to go missing in our Vagrant images.
> 
> Fix: Move the modules back to linux-modules.
> 
> Test Case: Build the kernel packages and confirm that the vboxguest and
> vboxsf drivers are now in linux-modules rather than linux-modules-extra.
> 
> Regression Potential: Since linux-modules is required, anyone who is
> using the vbox drivers will continue to have them after this change.
> Therefore the risk of regression is extremely low.
> 
> Note that the second patch is related, but optional. Since both vbox and
> zfs modules are built using dkms-build, it is not necessary to include
> them in generic.inclusion-list, and removing them gets rid of some noise
> in the build logs.
> 
> Thanks,
> Seth

Makes sense to me.

Acked-by: Andrea Righi <andrea.righi at canonical.com>

> 
> ---
> 
> Seth Forshee (2):
>   UBUNTU: [Packaging] Move virtualbox modules to linux-modules
>   UBUNTU: [Packaging] Remove vbox and zfs modules from
>     generic.inclusion-list
> 
>  debian.master/control.d/generic.inclusion-list | 3 ---
>  debian/rules.d/2-binary-arch.mk                | 2 +-
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team