ACK: [PATCH][focal] Remove amdgpu assert warnings if retimer is not available

Kleber Souza kleber.souza at canonical.com
Fri Apr 24 07:58:56 UTC 2020


On 24.04.20 02:55, Alex Hung wrote:
> 
> 
> On Thu, Apr 23, 2020 at 6:53 AM Kleber Souza <kleber.souza at canonical.com <mailto:kleber.souza at canonical.com>> wrote:
> 
>     On 13.04.20 20:46, Alex Hung wrote:
>     > BugLink: https://bugs.launchpad.net/bugs/1871248
>     >
>     > [Impact]
>     >
>     > amdgpu generates assert warning messages when retimer is not supported.
>     > This behaviour can cause confusions to users.
>     >
>     > [Fix]
>     >
>     > This is fixed by commit a0e40018dcc3f59a. It silences ASSERTs by
>     > outputing a debug message and exiting when retimer is not supported by
>     > hardware.
>     >
>     > [Test]
>     >
>     > Verified on B450 I AORUS PRO WIFI with AMD Ryzen 3 3200G as discussed
>     > on LP:1871248.
>     >
>     > [Regression Potential]
>     >
>     > Low. It is for unsupported hardware features, and the patch was cherry-picked
>     > from upstream kernel 5.7 rc1.
>     >
>     > Rodrigo Siqueira (1):
>     >   drm/amd/display: Stop if retimer is not available
>     >
>     >  drivers/gpu/drm/amd/display/dc/core/dc_link.c | 67 ++++++++++++---------------
>     >  1 file changed, 29 insertions(+), 38 deletions(-)
>     >
> 
>     Clean cherry-pick and with good test results:
> 
>     Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com <mailto:kleber.souza at canonical.com>>
> 
> 
> 
>     Alex,
> 
>     Can you please add the SRU template to the bug report?
> 
> 
> SRU is added to bug description LP:1871248. Let me know whether this is done correctly.

That's perfect, thanks!


Kleber

> 
> Thanks.
> 
> 
> 
>     Thanks,
>     Kleber
> 
> 
> 
> -- 
> Cheers,
> Alex Hung




More information about the kernel-team mailing list