ACK: [B][D][SRU][PATCH 0/4] Backport MPLS patches from 5.3

Kleber Souza kleber.souza at canonical.com
Thu Apr 23 13:39:49 UTC 2020


On 08.04.20 08:55, Po-Hsu Lin wrote:
> == SRU Justification ==
> Mellanox is requesting a backport of the following commit IDs from 5.3
> back to 5.0 and 4.15:
> * 5dc9520bf04a ("net/mlx5e: Report netdevice MPLS features")
> * 8b6912a50193 ("net: vlan: Inherit MPLS features from parent device")
> * 2e770b507ccd ("net: bonding: Inherit MPLS features from slave devices")
> * e4683f35f8e5 ("net/mlx5e: Move to HW checksumming advertising")
> 
> Netdevice HW MPLS features are not passed from device driver's netdevice
> to upper netdevice, specifically VLAN and bonding netdevice which are
> created by the kernel when needed.
> 
> This prevents enablement and usage of HW offloads, such as TSO and
> checksumming for MPLS tagged traffic when running via VLAN or bonding
> interface.
> 
> The patches introduce changes to the initialization steps of the VLAN
> and bonding netdevices to inherit the MPLS features from lower
> netdevices to allow the HW offloads.
> 
> == Fix ==
> * 5dc9520bf04a ("net/mlx5e: Report netdevice MPLS features")
> * 8b6912a50193 ("net: vlan: Inherit MPLS features from parent device")
> * 2e770b507ccd ("net: bonding: Inherit MPLS features from slave devices")
> * e4683f35f8e5 ("net/mlx5e: Move to HW checksumming advertising")
> 
> The first two patches can be cherry-picked into Disco, and the rest
> will require some context adjustment.
> 
> == Test ==
> Test kernels can be found here:
> https://people.canonical.com/~phlin/kernel/lp-1851446-MPLS-0407/
> 
> Kernel tested with positive test result and approved by their QA.
> 
> == Regression Potential ==
> Low, changes just for adding MPLS feature and comes with positive
> test result.
> 
> Ariel Levkovich (4):
>   net/mlx5e: Report netdevice MPLS features
>   net: vlan: Inherit MPLS features from parent device
>   net: bonding: Inherit MPLS features from slave devices
>   net/mlx5e: Move to HW checksumming advertising
> 
>  drivers/net/bonding/bond_main.c                   | 11 +++++++++++
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 11 +++++++----
>  net/8021q/vlan_dev.c                              |  1 +
>  3 files changed, 19 insertions(+), 4 deletions(-)
> 

LGTM.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>



More information about the kernel-team mailing list