ACK/cmnt: [SRU][E][PATCH 0/3] i915 hang fixes backported to 5.3

[Kleber Souza]

On 23.04.20 05:46, Sultan Alsawaf wrote:
> BugLink: https://bugs.launchpad.net/bugs/1872001
> 
> [Impact]
> Users of i915 on 5.3 experience GPU hangs.
> 
> [Test]
> Seems to happen often when using a Chromium-based browser with hardware
> acceleration enabled.
> 
> [Fix]
> Arighi backported three relevant fixes from upstream to fix the issue. I pulled
> them from https://git.launchpad.net/~arighi/+git/eoan-linux/log/?h=lp-1861395
> 
> [Regression Potential]
> High, but these patches do seem to fix the problem.

My laptop was also affected by this and I can confirm that these patches fix
the issue and I have not seen any regression for now. Changes to i915 are always
risky, but as we have a couple of other people affected reporting the issue
is gone and these patches have been applied to Focal already for some time
so I think we should apply these for next cycle.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

> 
> Sultan
> 
> Chris Wilson (3):
>   drm/i915/execlists: Preempt-to-busy
>   drm/i915/gt: Detect if we miss WaIdleLiteRestore
>   drm/i915/execlists: Always force a context reload when rewinding
>     RING_TAIL
> 
>  drivers/gpu/drm/i915/gem/i915_gem_context.c   |   2 +-
>  drivers/gpu/drm/i915/gt/intel_context_types.h |   5 +
>  drivers/gpu/drm/i915/gt/intel_engine.h        |  70 +-
>  drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  63 +-
>  drivers/gpu/drm/i915/gt/intel_engine_types.h  |  61 +-
>  drivers/gpu/drm/i915/gt/intel_lrc.c           | 716 ++++++++----------
>  drivers/gpu/drm/i915/gt/intel_ringbuffer.c    |   2 +
>  drivers/gpu/drm/i915/i915_gpu_error.c         |  19 +-
>  drivers/gpu/drm/i915/i915_request.c           |   6 +
>  drivers/gpu/drm/i915/i915_request.h           |   1 +
>  drivers/gpu/drm/i915/i915_scheduler.c         |   3 +-
>  drivers/gpu/drm/i915/i915_utils.h             |  12 +
>  drivers/gpu/drm/i915/intel_guc_submission.c   | 175 ++---
>  drivers/gpu/drm/i915/selftests/i915_request.c |   8 +-
>  14 files changed, 522 insertions(+), 621 deletions(-)
>