[SRU][U][PATCH 0/8] Fix TC port in legacy/static mode can't be detected due TCCOLD

You-Sheng Yang vicamo.yang at canonical.com
Wed Apr 22 07:04:12 UTC 2020


BugLink: https://bugs.launchpad.net/bugs/1868936

[Impact]
External monitor connected via a Type-C dongle when device is in PC10 may not be
light up.

[Fix]
Patches series https://patchwork.freedesktop.org/series/75941/ from
intel-gfx mailing list, which has been merged in drm-tip tree with tip
commit 0f8925090ac7.

[Test Case]
1. Ensure device may enter PC10.

   $ sudo powertop --auto-tune
   $ sudo watch cat /sys/kernel/debug/pmc_core/package_cstate_show

   Press Meta+L to lock screen for a while and unlock again, "Package
   C10" field should have non-zero counts.

2. Press Meta+L to lock screen again.

3. After screen turns black and wait a few more seconds, connect external
   monitor to a type C port via a type C dongle and wake the device.

4. Check if external monitor is also light up as an extended/mirrored
   screen.

[Regression Potential]
Medium.

José Roberto de Souza (8):
  drm/i915/display: Move out code to return the digital_port of the aux
    ch
  drm/i915/display: Add intel_legacy_aux_to_power_domain()
  drm/i915/display: Split hsw_power_well_enable() into two
  drm/i915/tc/icl: Implement TC cold sequences
  drm/i915/tc: Skip ref held check for TC legacy aux power wells
  drm/i915/tc/tgl: Implement TC cold sequences
  drm/i915/tc: Catch TC users accessing FIA registers without enable aux
  drm/i915/tc: Do not warn when aux power well of static TC ports
    timeout

 drivers/gpu/drm/i915/display/intel_display.c  |  14 +-
 drivers/gpu/drm/i915/display/intel_display.h  |   2 +
 .../drm/i915/display/intel_display_power.c    | 297 ++++++++++++++----
 .../drm/i915/display/intel_display_power.h    |   1 +
 drivers/gpu/drm/i915/display/intel_tc.c       |  94 +++++-
 drivers/gpu/drm/i915/i915_reg.h               |   5 +
 6 files changed, 350 insertions(+), 63 deletions(-)

-- 
2.25.1




More information about the kernel-team mailing list