[SRU][Eoan][PATCH 2/4] ASoC: SOF: Intel: hda: correct ROM state mask

Hui Wang hui.wang at canonical.com
Mon Apr 13 02:33:33 UTC 2020

From: Keyon Jie <yang.jie at linux.intel.com>

BugLink: https://bugs.launchpad.net/bugs/1872380

The ROM state is represented by the 24 LSB bits in the ROM status
register, so the mask should be 0xffffff instead of 0xf.

Signed-off-by: Keyon Jie <yang.jie at linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
Link: https://lore.kernel.org/r/20190722141402.7194-11-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie at kernel.org>
(cherry picked from commit 184fdfca4ba63d57a668564639a4dcf188fc9822)
Signed-off-by: Hui Wang <hui.wang at canonical.com>
 sound/soc/sof/intel/hda.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/intel/hda.h b/sound/soc/sof/intel/hda.h
index 9c316b72a2cb..12e8cf588ecc 100644
--- a/sound/soc/sof/intel/hda.h
+++ b/sound/soc/sof/intel/hda.h
@@ -174,7 +174,7 @@
 /* ROM  status/error values */
-#define HDA_DSP_ROM_STS_MASK			0xf
+#define HDA_DSP_ROM_STS_MASK			GENMASK(23, 0)
 #define HDA_DSP_ROM_INIT			0x1
 #define HDA_DSP_ROM_FW_FW_LOADED		0x4

More information about the kernel-team mailing list