ACK/cmt: [SRU][UNSTABLE][PATCH] UBUNTU: SAUCE: shiftfs: record correct creator credentials

Seth Forshee seth.forshee at canonical.com
Fri Apr 10 15:33:56 UTC 2020


On Fri, Apr 10, 2020 at 05:14:28PM +0200, Christian Brauner wrote:
> On Fri, Apr 10, 2020 at 10:06:32AM -0500, Seth Forshee wrote:
> > On Fri, Apr 10, 2020 at 04:55:28PM +0200, Christian Brauner wrote:
> > > From: Christian Brauner <christian.brauner at ubuntu.com>
> > > 
> > > BugLink: https://bugs.launchpad.net/bugs/1872094
> > > 
> > > When shiftfs is nested we failed to be able to create any files or
> > > access directories because we recorded the wrong creator credentials. We
> > > need to record the credentials of the creator of the lowers mark mount
> > > of shiftfs. Otherwise we aren't privileged wrt to the shiftfs layer in
> > > the nesting case. This is similar to how we always record the user
> > > namespace of the base filesystem.
> > > 
> > > Suggested-by: Seth Forshee <seth.forshee at canonical.com>
> > > Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
> > 
> > This looks right to me.
> > 
> > Acked-by: Seth Forshee <seth.forshee at canonical.com>
> > 
> > Not sure why you only sent this for unstable though. Shouldn't it also
> > go back to E/F?
> 
> Yes, it should go to all LTS kernels that do have shiftfs. The reason I
> only put UNSTABLE in the subject is because I developed in on top of it
> and it has HEAD~1 as base commit from unstable. Otherwise the patch
> should just apply cleanly to all LTS. Next time I can just tag all of
> them in the subject.

Yeah, I mean we do appreciate it if you confirm the patch applies at
minimum :-)

But I don't think we've let shiftfs diverge between releases, so it
should be fine.



More information about the kernel-team mailing list