[PATCH 0/1] [autotest] sfdisk: do not hardcode starting sector

[Sean Feole]

On 4/8/20 3:19 AM, Po-Hsu Lin wrote:
> Hi Paolo,
>
> for this kind of small change which is limited to a specific test case,
> not sure if this is a good idea, but I think at least you can just use
> our jenkins server directly as you need to check it on different
> arches.

Patching Autotest is the correct way to tackle this, since the 
partitioning for logic for sfdisk is stored in autotest itself. Each of 
the tests
call the autotest API (client/partitioning.py) to handle their storage 
devices.

-sfeole

> Just remember to let Sean and I know, and don't forget to watch the
> test result in case it causes some interruption for the ongoing tests.
>
> Note that it looks like this is for ubuntu_xfstests_*, as for the
> limited test resources and the time it needs for the test, we only
> have amd64 tested with it.
>
> On Mon, Apr 6, 2020 at 6:38 PM Paolo Pisati <paolo.pisati at canonical.com> wrote:
>> I tested it in Xenial, Bionic and Focal but only on amd64 - let me
>> spin it on some other arch.
>>
>> BTW, if i have an invasive autotest patch, is there a way for me to
>> spin a private autotest run on several arches/releases?
>> Or do i have to spin every single impacted test manually?
>> Create/allocate the target arch/release, install
>> autotest/autotest/client-tests, run the test, wash, rinse and repeat
>> for every arch/release target pair.
>>
>> On Mon, Apr 6, 2020 at 12:25 PM Colin Ian King <colin.king at canonical.com> wrote:
>>> On 06/04/2020 11:22, Paolo Pisati wrote:
>>>> BugLink: https://bugs.launchpad.net/bugs/1864642
>>>>
>>>> Every selftest unit test instantiating a virtual_partition class:
>>>>
>>>> $ git grep virtual_partition
>>>> ubuntu_xfstests_btrfs/control:vp = partition.virtual_partition(file_img=file_img, file_size=1024*1024)
>>>> ubuntu_xfstests_ext4/control:vp = partition.virtual_partition(file_img=file_img, file_size=1024*1024)
>>>> ubuntu_xfstests_xfs/control:vp = partition.virtual_partition(file_img=file_img, file_size=1024*1024)
>>>> xfstests/control:vp = partition.virtual_partition(file_img=file_img, file_size=1024*1024)
>>>>
>>>> will fail during _init_ with:
>>>>
>>>>>>> Created a new DOS disklabel with disk identifier 0x9b4a9cf7.
>>>> /dev/loop1p1: Start sector 0 out of range.
>>>> Failed to add #1 partition: Numerical result out of range
>>>> Leaving.
>>>>
>>>> because we hardcoded 0 as the starting sector: fix it by letting sfdisk pick
>>>> the first available sector.
>>>>
>>>> Paolo Pisati (1):
>>>>    UBUNTU: SAUCE: sfdisk: let sfdisk decide the first available
>>>>      sector
>>>>
>>>>   client/partition.py | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>> Does this work on every release with non-powerpc arches too?
>>
>>
>> --
>> bye,
>> p.
>>
>> --
>> kernel-team mailing list
>> kernel-team at lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team

-- 
-Sean Feole

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200409/e46fb28b/attachment.html>