[SRU][E][PATCH 0/2] remove prog_tests/sockmap_basic.c from bpf selftests

Kleber Sacilotto de Souza kleber.souza at canonical.com
Thu Apr 9 13:28:59 UTC 2020

BugLink: https://bugs.launchpad.net/bugs/1871613

We have backported to eoan/linux some patches from 5.4.y upstream stable
that added a new testcase for selftests/bpf
(prog_tests/sockmap_basic.c). Eoan 5.3 kernel doesn't have several
pre-req commits for this testcase, so compilation fails:

prog_tests/sockmap_basic.c: In function 'connected_socket_v4':
prog_tests/sockmap_basic.c:22:6: warning: implicit declaration of function 'CHECK_FAIL' [-Wimplicit-function-declaration]
   22 | if (CHECK_FAIL(s == -1))
      | ^~~~~~~~~~
prog_tests/sockmap_basic.c:26:22: error: 'SOL_TCP' undeclared (first use in this function); did you mean 'SOL_TIPC'?
   26 | err = setsockopt(s, SOL_TCP, TCP_REPAIR, &repair, sizeof(repair));
      | ^~~~~~~
      | SOL_TIPC
prog_tests/sockmap_basic.c:26:22: note: each undeclared identifier is reported only once for each function it appears in
prog_tests/sockmap_basic.c: In function 'test_sockmap_basic':
prog_tests/sockmap_basic.c:75:6: warning: implicit declaration of function 'test__start_subtest' [-Wimplicit-function-declaration]
   75 | if (test__start_subtest("sockmap create_update_free"))
      | ^~~~~~~~~~~~~~~~~~~

I am proposing to revert the commits that added this testcase as there
it would need a number of other commits to make it work.

Kleber Sacilotto de Souza (2):
  UBUNTU: SAUCE: Revert "bpf: Selftests build error in sockmap_basic.c"
  UBUNTU: SAUCE: Revert "selftests/bpf: Test freeing sockmap/sockhash
    with a socket in it"

 .../selftests/bpf/prog_tests/sockmap_basic.c  | 79 -------------------
 1 file changed, 79 deletions(-)
 delete mode 100644 tools/testing/selftests/bpf/prog_tests/sockmap_basic.c


More information about the kernel-team mailing list