APPLIED[F]/cmt: [SRU][F/E][PATCH 0/6] alsa: make the dmic detection align to the mainline kernel-5.6

Seth Forshee seth.forshee at canonical.com
Tue Apr 7 19:51:07 UTC 2020


On Tue, Apr 07, 2020 at 03:14:36PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1871284
> 
> This patchset is already in the upstream kernel-5.6, so no need to
> send for unstable.
> And this patchset will remove an existing kernel module and add a new
> kernel module, so need to change the ABI/modules.ignore manually.
> The module removed: snd-intel-nhlt.ko
> The module added:   snd-intel-dspcfg.ko
> 
> [Impact]
> There is already dmic detection code in the eoan and focal kernel, it
> works well on CNL/WHL and later Intel platforms, but it doesn't work
> on KBL, SKL and old Intel machines.
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/14
> 
> [Fix]
> The upstream kernel updated the dmic detection code, it will exclude the
> old intel machines by default. Then the old machines will use legacy hda
> driver like before.
> 
> [Test Case]
> Install the testing kernel to Dell/LENOVO WHL/CNL and later machines,
> they work as well as before.
> 
> And a user verifed the testing kernel work on his KBL machine.
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/17
> 
> [Regression Risk]
> Low, those patches come from mainline kernel, I have tested those patches
> on the WHL/CNL and later machiens, a user tested it on a KBL machine.

On the config change, it looks like you forgot to run updateconfigs (as
I see additional changes when running it), and the annotations file does
not carry annotations for options which are not user selectable. Since
these options are only selected by other options, you should enforce the
required user-selectable options instead.

Applied to focal/master-next, with the last patch updated with the
results of running updateconfigs and removing the annotations changes.
Thanks!



More information about the kernel-team mailing list